Date: Fri, 25 Aug 2006 14:39:33 +0100
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jan Bernatik <jan.bernatik@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: platform device / driver question
Message-ID: <20060825133933.GC2287@flint.arm.linux.org.uk>
Mail-Followup-To: Jan Bernatik <jan.bernatik@gmail.com>,
	linux-kernel@vger.kernel.org
References: <dca824fc0608250608s3b371291qd313986cffc1e028@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dca824fc0608250608s3b371291qd313986cffc1e028@mail.gmail.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 982
Lines: 22

On Fri, Aug 25, 2006 at 03:08:51PM +0200, Jan Bernatik wrote:
> I studied smc91x driver to understand how platform driver / device
> subsystem works. On #kernelnewbies channel I was told this driver is
> "hopelessly broken". How should one create and register the
> platform_device/driver ? Is the implementation in smc91x correct ?

That's probably from some ill-informed person.  As far as I'm aware,
the driver works perfectly and uses the driver model correctly.

There are some aspects of the driver which are less good (such as all
the machine specific configuration gunk in smc91x.h) but apart from
that, it's fine.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/