Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp725096pxu; Mon, 23 Nov 2020 02:27:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxN2DJXph7+PoMIUY60DP/3J8zJmIrER3rgbAn5nq6ThvLPAhoBNiOCnzLbOYYRmzHC4aJA X-Received: by 2002:a17:906:1e93:: with SMTP id e19mr23009109ejj.440.1606127251633; Mon, 23 Nov 2020 02:27:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606127251; cv=none; d=google.com; s=arc-20160816; b=PUWk95wx74XqGO7fGF9i5VaPRSls1vbJWvAIYojab69cUR/iCkhP1yIPXM10LBdD5m WdjUR0UY3Oi3rq8mWnI/tA1wct1TJ9FrGkk8/VCCkSYNqVPd+d3/erCDebjf6KVC7AJ/ UvTwvuVgO1iHet1uCm2dHSbE+vc729NJ+2m+YV7RaW+9rLXweTcGEbVlhxlv3B1Rilpm qyBHIEQa0Nyz7cxaYeRlfDAww2UZ2ikMt1Hg0bGiRDbeMJu5FH05w9bHtH3bVgK/X8ba zif3+bMg8s97EQpyI43QAgshROb5LBAaTg19cdGOdYezQ8RyicM3GX0hWsKAHFuB616m GOIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m2/dM0fiZFFaVmOHUldEXcGmQWn8Jr9SAh0wPU5gbj0=; b=Cw7Y4McP/8ShT/2nHq2cz7K55onuvwSTP097MWoLoD45jPm/aPGeYCw5VVRUtg9zIm G4c+VkK7BDhpCsYHnaAVl0KXWYr56efKVwVnY7ocMj6PtrFRVGZuNz0ITaVoGN5m0HEU NdcluXMA8g3VeDKx815Jna4VI5Fk+8rmyh6sPyHQfsaOBXNzN12Y+6CvgeMisBdIg9tI Iib4vCrLDon6TQ9ygbbA3oaRo3V1Qjb43PG1tOXl8iEpUjrJlPDv9cskXO+6ap6fYB7G +lALiJojUkuZQE9QnDv0uqdSa/Z7FQYcpvPCgFC1f0epwrioqpbXeOpBKfcYz8eSRAVi WxWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=xdilp649; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n18si6051756eje.443.2020.11.23.02.27.08; Mon, 23 Nov 2020 02:27:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=xdilp649; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbgKWKWH (ORCPT + 99 others); Mon, 23 Nov 2020 05:22:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727984AbgKWKWG (ORCPT ); Mon, 23 Nov 2020 05:22:06 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE2EC061A4D for ; Mon, 23 Nov 2020 02:22:06 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id c198so15468486wmd.0 for ; Mon, 23 Nov 2020 02:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m2/dM0fiZFFaVmOHUldEXcGmQWn8Jr9SAh0wPU5gbj0=; b=xdilp649Fuj21dkVTPgC3MH7YkEUop9b7ELDJZc7oLaFgQVfEAODOZBiZL+nzQ9F3z AYi6UKfT37LQaYld5fvNCn5PhejTzrgzma+Z+8elyjCVU3q0E2eDBktqxpmCEn5bD8Mo e3YSS6if3Zfv1O7hX1k2vpEgiDfgpnacHQo/ut+b6vKU4OWgal3iPf1iT2BkKgKI8I7I PNbRIC8mrdMyvKX1HRzbHaoQSM2DaBVUJ3Ymjhy4HuPy7n2eNhnyNnv+BefIowc5MEMM xNjGiIyRhlaJmFbvXkvXZeLtrxnjAPbuPdvwuQbucW8Jc6Qcs49B5eC+bYK9hf2V+923 hl0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m2/dM0fiZFFaVmOHUldEXcGmQWn8Jr9SAh0wPU5gbj0=; b=FMY0UITwBHJyno6lr7pOFo7ZbyUdVmcZ/DP7HPIlEgQTCOEJFE9c63j3hYOd1EXpO0 Wgb7QMPbnaKvos1+NQgAmLg/s7i6YdJmd+RB+l+e/SD5SiNq4kt8p3JXOAXXerMMrscB kqYEaif0jeV6FMQVjmG9xGgdZAeUGihlUeYXQYrMGmorsmgAIGyUwl39WwVsWwR1rtW2 OGqzSjylu37vqOwq153AtHFm6mJyzVMiEA1Temk4hXqyyfRoQtbXU8rCWRzlJTkhJ+qr R2baIjDqZ2y+RxyOqsjTrdYIjLnFI/PpnymzotOuVlZuXG0otvyaT7owgO8DjRPkLRD7 MtFw== X-Gm-Message-State: AOAM531iIfg4D+z2clPyFQ9Ck+d1T2FM/TI7zwJwvFJnRL6kooTPP2XP erXrrZiS3svmzIX+WLJiFOIiWQ== X-Received: by 2002:a1c:1c3:: with SMTP id 186mr22816096wmb.39.1606126925037; Mon, 23 Nov 2020 02:22:05 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id d15sm19893678wrx.93.2020.11.23.02.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 02:22:04 -0800 (PST) Date: Mon, 23 Nov 2020 11:22:03 +0100 From: Jiri Pirko To: George Cherian Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "davem@davemloft.net" , Sunil Kovvuri Goutham , Linu Cherian , Geethasowjanya Akula , "masahiroy@kernel.org" , "willemdebruijn.kernel@gmail.com" , "saeed@kernel.org" Subject: Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA Message-ID: <20201123102203.GH3055@nanopsycho.orion> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Nov 23, 2020 at 03:49:06AM CET, gcherian@marvell.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko >> Sent: Saturday, November 21, 2020 7:44 PM >> To: George Cherian >> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; >> kuba@kernel.org; davem@davemloft.net; Sunil Kovvuri Goutham >> ; Linu Cherian ; >> Geethasowjanya Akula ; masahiroy@kernel.org; >> willemdebruijn.kernel@gmail.com; saeed@kernel.org >> Subject: Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health >> reporters for NPA >> >> Sat, Nov 21, 2020 at 05:02:00AM CET, george.cherian@marvell.com wrote: >> >Add health reporters for RVU NPA block. >> >NPA Health reporters handle following HW event groups >> > - GENERAL events >> > - ERROR events >> > - RAS events >> > - RVU event >> >An event counter per event is maintained in SW. >> > >> >Output: >> > # devlink health >> > pci/0002:01:00.0: >> > reporter npa >> > state healthy error 0 recover 0 >> > # devlink health dump show pci/0002:01:00.0 reporter npa >> > NPA_AF_GENERAL: >> > Unmap PF Error: 0 >> > Free Disabled for NIX0 RX: 0 >> > Free Disabled for NIX0 TX: 0 >> > Free Disabled for NIX1 RX: 0 >> > Free Disabled for NIX1 TX: 0 >> >> This is for 2 ports if I'm not mistaken. Then you need to have this reporter >> per-port. Register ports and have reporter for each. >> >No, these are not port specific reports. >NIX is the Network Interface Controller co-processor block. >There are (max of) 2 such co-processor blocks per SoC. Ah. I see. In that case, could you please structure the json differently. Don't concatenate the number with the string. Instead of that, please have 2 subtrees, one for each NIX. > >Moreover, this is an NPA (Network Pool/Buffer Allocator co- processor) reporter. >This tells whether a free or alloc operation is skipped due to the configurations set by >other co-processor blocks (NIX,SSO,TIM etc). > >https://www.kernel.org/doc/html/latest/networking/device_drivers/ethernet/marvell/octeontx2.html >> NAK.