Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp732487pxu; Mon, 23 Nov 2020 02:42:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfMVSlu88MXF66Zk1quzcJ4WVi2oZnCtuHHrrbL9aOTQRqOxwUEzoofHuLymXIPXYtRt6l X-Received: by 2002:a05:6402:2363:: with SMTP id a3mr20656136eda.388.1606128178504; Mon, 23 Nov 2020 02:42:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606128178; cv=none; d=google.com; s=arc-20160816; b=Ue+Gr4EHYudQvWCGJ2Rnpvdi9Ehgut3pdod9wQjNCbbMff4dldNM9CpJnqzpxPCPzF o/3KPFq54cJ58sHR9jyWbv0jzsR0DgMVJhtQ/qRURM4MxFtzHsk11SEfkokLRDjEqoDh 5EEvK68Dk/em+cwBSXfnzf4vY0jYUBTs+GwSibLwnBTtUnnlLKJhcNe92G3Mt8e3Cz2t Ov+E94EbuykHdS4S8ktNVeBF8tdxjrn2fAVaTF6coVC6aKfkBHpawPwUdtQdPnMUzaO/ FdrB+UrUjfMSfjksFG8KFKpsQmTo1dF91wmwRdfxoUtG14wlPHtNzapl1AugOTEIBl4c 3w5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=rja4mFvPtVCeH4UELYSy3t07Yo+UPDvUCyzzCQixKww=; b=He2Hcrp121XnWClhanoRtwX/Cr2fCmbSni/G5Tya3yjSYK5UtJg1yfSuLUhfca8por TT17FGr9d8O6LCBE/d3W/u7wDjPUeTdq6THTr8dhpQgfWOyCjE2l/UZV3sXlue5LcpVN jx2uuMo+pnvDRNzMjKzwyqw1hIvfW5h5EczZZYg5Qe1/MSfhJ8jimGCKAANpgHI5YqKO DTdPeTRHOz8d5wW0m5RriwCZ/xDIlEsn72yoKVhMT28oYQownYe2jDk0pAQGB8R46xCE zjrfnw6Ge2xGm6bH/2knyhccREfjfCQgfv5hkGGvdfl5/mIMHZfK6ran8e93P4yBMOQW 4IBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X1usOJU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si6533173edn.212.2020.11.23.02.42.35; Mon, 23 Nov 2020 02:42:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X1usOJU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbgKWKi3 (ORCPT + 99 others); Mon, 23 Nov 2020 05:38:29 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3872 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbgKWKi3 (ORCPT ); Mon, 23 Nov 2020 05:38:29 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 23 Nov 2020 02:38:31 -0800 Received: from [10.26.72.66] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Nov 2020 10:38:26 +0000 Subject: Re: [PATCH v5 0/6] Tegra210 audio graph card To: Sameer Pujar , , , CC: , , , , , References: <1605119676-32273-1-git-send-email-spujar@nvidia.com> From: Jon Hunter Message-ID: Date: Mon, 23 Nov 2020 10:38:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1605119676-32273-1-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606127911; bh=rja4mFvPtVCeH4UELYSy3t07Yo+UPDvUCyzzCQixKww=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=X1usOJU0UqprKtf9SA4DFxYJrh+6K9X8SYt/mat5kG4dSMka4gKP49pcyT+p8VgMd C+RHSlT9DCECut9i25KXabM0IxvutDNtWbugyunFjn0LqQlhgoJXa+ta3UkfzVm4XO XEF+/6ueRwEjEcEWdzXXOOej6W5Qgd80k5W+UWwjNrurK3OhrJJ+i87dEmtGhT7pfr E1wGOeL9KWUjTZkz1tKSi1j9C8Eyvq1PfaSQ83Ks9XxpXcJ52QNV0EZAf5zjx8aI5D ntYZjtEFwhHiXVgiCJxXImRFz5M4DgFwlR6ST45KR+i02u0QRE2bwMHBRBHVs2/CQf KiJk20Zt8/N0Q== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2020 18:34, Sameer Pujar wrote: > This series adds audio graph based sound card support for Tegra210 > platforms like Jetson-TX1 an Jetson-Nano. The following preparatory > audio graph enhancement series is already merged. > * https://patchwork.kernel.org/project/alsa-devel/list/?series=375629&state=* > > Following are the summary of changes: > * Add graph/audio-graph based schemas or schema updates for Tegra210 > component and machine drivers. > * Add Tegra audio graph machine driver. > * Add required DT support for Jetson-TX1/Nano. > > This work is based on earlier discussion of DPCM usage for Tegra > and simple card driver updates. > * https://lkml.org/lkml/2020/4/30/519 > * https://lkml.org/lkml/2020/6/27/4 > > This series has dependency over following graph and audio-graph series. > * http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20201102203656.220187-2-robh@kernel.org/ > * https://patchwork.kernel.org/project/alsa-devel/list/?series=382009&state=* Only one minor comment, but this looks good to me. Otherwise for the series ... Reviewed-by: Jon Hunter Cheers Jon -- nvpublic