Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp767683pxu; Mon, 23 Nov 2020 03:46:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/HvGZsCgEhPhbDlmXCuWYNgd/WUKhbuECCGgCJELJsCmwT+cVeaCFnvnTK+zxvGM7sTGt X-Received: by 2002:a17:906:6683:: with SMTP id z3mr7255594ejo.27.1606131971409; Mon, 23 Nov 2020 03:46:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606131971; cv=none; d=google.com; s=arc-20160816; b=MSF0CHk1Rf1K0IAEpBFCw2U9c70dKO2QITuv8c3POhcp9oslpujmY/ijsJ822qMudr 3vRwfKD2w+NsLKeRZ4s4OvR1duoPCqrSDhlkaCdtHN9BVJ9iuak1RY2Wlt3O3X5uCy06 XMih8aMXrGtP1bXRHmBFa5XBO97I1cHvChHuQS/YDPJ+LFapjydb9q0S+deyreCvaB2D /6Gzs9d1+w1jH8ZEb1Q/18UiRg6HNGCoSNssIEr5cx/lCiZGGgui3/Vv/7MDo2cVGHfT F81cSWHhikkuKX2IshMH7DjegN+vFJ9DT4Qdfr2f6zdcWBH123MHCX7F/khFvaEB3/Ix MIeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=MRDouhLOVoBjmxW/e0QfNvtmZerj8ya+mSvcedhOJL0=; b=zP0+NiJsDyABamHX6OUAroGqqm3fvlo7Rs297c8H5N0QMWReoxZXOri1gT75Vjdc7R QZG+kciNFYZ50wfRCx+cvbRPVoRN+Do7RZUG8iLDmEgS7CgBsx34+4MgG2CufZclg2hT SzZ46Bb6an30+di7H0PKLw+6pKDPF5LTogp1pCuCBB9yWGsoW5Tcx6DHdGDFZlznm4KQ SOZaAsJ0eKN+COt1W9R1mUIvEajAZ0A16jLnJ7h7Kz9gf2dUeJ7i5i2IAQfJbv6vDalB q2f8Buves9JrUjX/wsFDYWQDPLBcWIJ++38OEGEZbrX7iStJCqoTEyBZvhgvPTOsROL2 9haQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si6754612edq.224.2020.11.23.03.45.48; Mon, 23 Nov 2020 03:46:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729024AbgKWLl3 convert rfc822-to-8bit (ORCPT + 99 others); Mon, 23 Nov 2020 06:41:29 -0500 Received: from mga03.intel.com ([134.134.136.65]:12280 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726745AbgKWLl3 (ORCPT ); Mon, 23 Nov 2020 06:41:29 -0500 IronPort-SDR: AG6W93Bpxo9RNEsjq4Ejd+izKo3I+O6JkASrHXYEjjQvSoIxim0OW7KnUOYCotv+H+TTygFlHx L9JLBv6YlZ/A== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="171843013" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="171843013" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 03:41:28 -0800 IronPort-SDR: M0DrrngnZ5QAuafz2LKL8uJJcVxUHY8rHBEDDWflWBO/t/j2ONoT9kuRspRi89yLe6neB+9QDe /oHHqm27B2tA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="536068727" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 23 Nov 2020 03:41:28 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 03:41:27 -0800 Received: from irsmsx601.ger.corp.intel.com (163.33.146.7) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 19:41:25 +0800 Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by irsmsx601.ger.corp.intel.com ([163.33.146.7]) with mapi id 15.01.1713.004; Mon, 23 Nov 2020 11:41:23 +0000 From: "Rojewski, Cezary" To: Andy Shevchenko , lkp CC: "kbuild-all@lists.01.org" , "linux-kernel@vger.kernel.org" , Mark Brown Subject: RE: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here Thread-Topic: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here Thread-Index: AQHWwD/eDLOgu+KuP0GoPmNta8oBHKnVjTKAgAAM/lA= Date: Mon, 23 Nov 2020 11:41:23 +0000 Message-ID: <8cb2dcbdef2446238c6a1fe8e8b74504@intel.com> References: <202011220325.oB7oeTEq-lkp@intel.com> <20201123105317.GZ4077@smile.fi.intel.com> In-Reply-To: <20201123105317.GZ4077@smile.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-23 11:53 AM, Andy Shevchenko wrote: > On Sun, Nov 22, 2020 at 03:52:27AM +0800, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 27bba9c532a8d21050b94224ffd310ad0058c353 >> commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 ASoC: Intel: Select catpt and deprecate haswell >> date: 7 weeks ago >> config: x86_64-randconfig-m001-20201122 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> smatch warnings: >> sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here > > ... > >> a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29 652 for (res = cdev->dram.child; res->sibling; res = res->sibling) >> a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29 653 ; >> a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29 @654 __request_region(&cdev->dram, res->end + 1, > > > This sounds like false positive. From where it gets the idea of resource_size() > for the *start* offset?! > Indeed it is false positive. I've already explained this in: RE: [bug report] ASoC: Intel: catpt: Firmware loading and context restore https://www.spinics.net/lists/alsa-devel/msg117145.html Regards, Czarek