Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201120162344.485921-1-krzk@kernel.org> <20201120162344.485921-2-krzk@kernel.org>
In-Reply-To: <20201120162344.485921-2-krzk@kernel.org>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 23 Nov 2020 17:07:10 +0100
Message-ID: <CAPDyKFre-8=tTShjRF+Pm2cQkGnN3HHcO42SgmCEfRzLoHDNTA@mail.gmail.com>
Subject: Re: [PATCH 2/2] mmc: sdhci-st: drop of_match_ptr from of_device_id table
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 20 Nov 2020 at 17:23, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).  This fixes
> compile warning (!CONFIG_OF on x86_64):
>
>     drivers/mmc/host/sdhci-st.c:512:34: warning:
>         =E2=80=98st_sdhci_match=E2=80=99 defined but not used [-Wunused-c=
onst-variable=3D]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 4e9ff3e828ba..962872aec164 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -523,7 +523,7 @@ static struct platform_driver sdhci_st_driver =3D {
>                    .name =3D "sdhci-st",
>                    .probe_type =3D PROBE_PREFER_ASYNCHRONOUS,
>                    .pm =3D &sdhci_st_pmops,
> -                  .of_match_table =3D of_match_ptr(st_sdhci_match),
> +                  .of_match_table =3D st_sdhci_match,
>                   },
>  };
>
> --
> 2.25.1
>