Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mkshah=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1F075C433C6
Subject: Re: [PATCH] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies
 to avoid build error
To:     John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>
Cc:     Todd Kjos <tkjos@google.com>,
        Saravana Kannan <saravanak@google.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org
References: <20201121063302.84090-1-john.stultz@linaro.org>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <e860242d-9024-0f68-9b83-ef4938fc17d8@codeaurora.org>
Date:   Mon, 23 Nov 2020 22:25:29 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201121063302.84090-1-john.stultz@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Precedence: bulk

Hi John,

Thanks for the patch.

On 11/21/2020 12:03 PM, John Stultz wrote:
> The kernel test robot reported the following build error:
>
> All errors (new ones prefixed by >>):
>
>     xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel':
>     qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write'
>     xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request':
>     qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write'
>     xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel':
>>> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async'
>     xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request':
>     qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async'
>
> Which is due to REGULATOR_QCOM_RPMH depending on
> QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now
> be a module, which in that case requires REGULATOR_QCOM_RPMH=m
> to build.
>
> However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be
> set to =y while REGULATOR_QCOM_RPMH=m which will cause build
> failures.
Seems typo here, you mean to say, REGULATOR_QCOM_RPMH can be set to =y 
while QCOM_RPMH=m....
>
> The easy fix here is to remove COMPILE_TEST.

As config QCOM_RPMH also has COMPILE_TEST, i don't see why it should be 
removed from REGULATOR_QCOM_RPMH.

Can REGULATOR_QCOM_RPMH have depends on ARCH_QCOM set similar to 
QCOM_RPMH? As test bot reported build errors on other ARCH with 
regulatore driver of QCOM arch.

Thanks,
Maulik

>
> Feedback would be appreciated!
>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Saravana Kannan <saravanak@google.com>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: Maulik Shah <mkshah@codeaurora.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>   drivers/regulator/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 020a00d6696b..9e4fc73ed5a1 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -843,7 +843,7 @@ config REGULATOR_QCOM_RPM
>   
>   config REGULATOR_QCOM_RPMH
>   	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
> -	depends on QCOM_RPMH || COMPILE_TEST
> +	depends on QCOM_RPMH
>   	help
>   	  This driver supports control of PMIC regulators via the RPMh hardware
>   	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation