Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1064252pxu; Mon, 23 Nov 2020 10:40:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyIMPXoA2C/WtDdgQs6UsWQ4d9z5yAsjuDGkEA9J/2CWVTsw+6QE34cv8Lb+PvoswaXmH6d X-Received: by 2002:aa7:c30e:: with SMTP id l14mr492193edq.315.1606156841500; Mon, 23 Nov 2020 10:40:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606156841; cv=none; d=google.com; s=arc-20160816; b=lI+eivlSVx3ByNUSaaGYXNdwlnbKHQUx4JYHnbjjBuNboG68H9DYcZYrUOTjOXgqrm cTf++UFx/yoGWa94Cwk1FfrwHQppLJOypjbAI4/k83xop4CvAiRLPgxH3clE0x29xkl4 /wYqXQ+jzwQmk3QpUPE+929TBf76lHRr52WDjc0qbBjALyPn7HSnOQ/zuR1HXLr8/xrt CEXPErFQr1gvl29eH81sfjZg8CZCiAw92SLEuRXgGL4ovxbRjkWWer/D4DHsPcHKUjem gQWEMSJ+O9Nye5xkuV0nh4OJUkiBZq5+rRmqdF6Ohju1e6ckQeImBAKnb9y+MPERhiXO 03Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TsGEqD4mSW3SlF4Kb0Ry8uHXIV5mwyuqKgsV7VqVcSM=; b=vVYn4VgUgKtm93G1X3M+pDReJMVfe3nfxMmghv3/ycEAVss6PoRuhlUHN64VOiRfkB txKhqJq9bsJWARgbeb7fwUG8wWWnvYGNhMEP3bJoRfzQ6XessGk3YOIPO+O79EihOsYQ 1MNWbTwNM45OAWa7Zm3Gq/oRB1dSSRuwkcFR6qQmioc9p1pDYecifXTToP/eT8YoZwib pBL2Zh6e6nzZ224v0fFkZ+kAjMols/qEM4hLYpLDnOCFic3hrEgny1xxcpsNWrFXjE+a 3CO/uQ7+x8yXgknz55uXjeiCX/Zjyz3oJ4TfQqlX9/OxEJ3B6iFc8WeTfPvSsBjQGI3G AJKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk3si8633477ejb.539.2020.11.23.10.40.17; Mon, 23 Nov 2020 10:40:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387843AbgKWSiv (ORCPT + 99 others); Mon, 23 Nov 2020 13:38:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:59388 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730490AbgKWSit (ORCPT ); Mon, 23 Nov 2020 13:38:49 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9527ACA2; Mon, 23 Nov 2020 18:38:47 +0000 (UTC) From: Nicolas Saenz Julienne To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, wahrenst@gmx.net, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org, sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com, andy.shevchenko@gmail.com, Nicolas Saenz Julienne Subject: [PATCH v5 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind Date: Mon, 23 Nov 2020 19:38:27 +0100 Message-Id: <20201123183833.18750-7-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201123183833.18750-1-nsaenzjulienne@suse.de> References: <20201123183833.18750-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 5d1aacdd84ef..068715d6e66d 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev) return -ENODEV; } - rpi_domains->fw = rpi_firmware_get(fw_np); + rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np); of_node_put(fw_np); if (!rpi_domains->fw) return -EPROBE_DEFER; -- 2.29.2