Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1077638pxu; Mon, 23 Nov 2020 11:03:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBLlJvVZPKUXYFSA2xpZNauTfnXSGXnCGSK62FpbZD80qeH9x+KpQnYhiWywYF2FBRNOo4 X-Received: by 2002:a17:906:138c:: with SMTP id f12mr1037761ejc.108.1606158206465; Mon, 23 Nov 2020 11:03:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606158206; cv=none; d=google.com; s=arc-20160816; b=r2HunhfHXCPiLtflTLHKOQuH99zf5/1f+klmMtgOKb8rIc/OfzmqOg4NxQIeBCu6jE cGKzJVCFPc3VnBmAxJqVHT0A/xMSLNk0rtACN93pR+nk/KlXToil733N9T4t04PhqKnT WmArtE7pLJf/DF/Wl42H+BGQaOtuRZOYFiCUszpS52qRsFuqf7700N5j5KT2yYi1kJYG iTuY/kSpXvbNz3TtrURyDGIUtVVw64y0DchVnvsqUO6vd7k46aOS5XETJgNA18lYZonI ng9liyNmu+BAzZKnVJAf1h4B4LRc99jTCNu2NjXqV5f1JSDTS5mJhOyCjn7I8d/oL9l6 UBLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=cQOOEZHk9E7IMSrqdkSjQAynq19K5cTIYzc1PC5TT/4=; b=rHK3r5hNlxx0eW4uhEOGpq5ZaFTsChC0+Pxq1PMknFAkF7khQQo4c7BKkvf/dSFCmh JfEOaDUkrruxNVG7NTwctWTN1stcLRnxZbxB3BDt45YMTGtccRbblU7Eier7KQBJT20Y 6ytqec/2W75d9lOtk9dKijN/e5GhFxJ256V7J0oEI4Pj2N/gFvlTu6DjsoLnv/HS7qwk uaqUYTU78ItTvX5rOQQc3ZQmRNlOeVbPDVEYFFkI2yH1MpSqSH7mArGGZON1S4z56/5d 1k5KajOGBzbGmzcgDMgihZ9ZNQEhEQ2JcVPZYJwR1pnG9NFqYx6+8khlftYioV4hVVoA QlqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="TKk4/A8p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b25si7107084edt.310.2020.11.23.11.03.02; Mon, 23 Nov 2020 11:03:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="TKk4/A8p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390586AbgKWTBi (ORCPT + 99 others); Mon, 23 Nov 2020 14:01:38 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:4091 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730868AbgKWTBe (ORCPT ); Mon, 23 Nov 2020 14:01:34 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 23 Nov 2020 11:01:37 -0800 Received: from [10.2.49.186] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Nov 2020 19:01:32 +0000 Subject: Re: [PATCH v2 3/6] dt-bindings: ata: tegra: Convert binding documentation to YAML To: Rob Herring CC: Thierry Reding , Jon Hunter , , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , linux-tegra , "linux-kernel@vger.kernel.org" References: <1605296218-2510-1-git-send-email-skomatineni@nvidia.com> <1605296218-2510-4-git-send-email-skomatineni@nvidia.com> From: Sowjanya Komatineni Message-ID: <0a6e99c8-9149-8756-3511-d4cb1814d3c6@nvidia.com> Date: Mon, 23 Nov 2020 11:01:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606158097; bh=cQOOEZHk9E7IMSrqdkSjQAynq19K5cTIYzc1PC5TT/4=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=TKk4/A8pGOgG08SCtA6LrP5Mt8p0MR+F6vDXfAuCDGOsdINHQQ4kkyDKoehi2cybL Amccb+8ZWdjsKIKS5ciDyerdCOaZ0Ss/C9r0MUtiIChI4x+NdzgPibAodfBqdlBbDv M6l6S1zXToRJOIIe9A+ivRnrUxtJEb5A9tZnE2PNv6kPxt3gvPpWbQCd11hRzHxeSZ Djc6ICGbRwX7oy+v4Lbaxatyae4JaYLhu3bpvEzOCuQgR6kJ0pPoczoqlII2p9s7WN fWfHvENmhK5lCnqoTFzwXS4byuIn8PDbTQdBQWVx39KIRtJs6L7zi9qLa1LoHIn0G2 zRP812XO6DkpA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/20 12:17 PM, Rob Herring wrote: > On Fri, Nov 13, 2020 at 1:36 PM Sowjanya Komatineni > wrote: >> This patch converts text based dt-binding document to YAML based >> dt-binding document. >> >> Signed-off-by: Sowjanya Komatineni >> --- >> .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 137 +++++++++++++++++++++ >> .../bindings/ata/nvidia,tegra124-ahci.txt | 44 ------- >> 2 files changed, 137 insertions(+), 44 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> >> diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> new file mode 100644 >> index 0000000..dbbe460 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml >> @@ -0,0 +1,137 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/ata/nvidia,tegra-ahci.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Tegra AHCI SATA Controller >> + >> +maintainers: >> + - Thierry Reding >> + - Jonathan Hunter >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra124-ahci >> + - nvidia,tegra132-ahci >> + - nvidia,tegra210-ahci >> + >> + reg: >> + minItems: 2 >> + maxItems: 3 >> + items: >> + - description: AHCI registers >> + - description: SATA configuration and IPFS registers >> + - description: SATA AUX registers >> + >> + interrupts: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: sata >> + - const: sata-oob >> + >> + clocks: >> + maxItems: 2 >> + >> + reset-names: >> + items: >> + - const: sata >> + - const: sata-cold >> + - const: sata-oob >> + >> + resets: >> + maxItems: 3 >> + >> + phy-names: >> + items: >> + - const: sata-0 >> + >> + phys: >> + maxItems: 1 >> + >> + hvdd-supply: >> + description: SATA HVDD regulator supply. >> + >> + vddio-supply: >> + description: SATA VDDIO regulator supply. >> + >> + avdd-supply: >> + description: SATA AVDD regulator supply. >> + >> + target-5v-supply: >> + description: SATA 5V power regulator supply. >> + >> + target-12v-supply: >> + description: SATA 12V power regulator supply. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clock-names >> + - clocks >> + - reset-names >> + - resets >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - nvidia,tegra124-ahci >> + - nvidia,tegra132-ahci >> + then: >> + properties: >> + reg: >> + maxItems: 2 >> + reset-names: >> + minItems: 3 >> + resets: >> + minItems: 3 >> + required: >> + - phys >> + - phy-names >> + - hvdd-supply >> + - vddio-supply >> + - avdd-supply >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - nvidia,tegra210-ahci >> + then: >> + properties: >> + reg: >> + minItems: 3 >> + reset-names: >> + minItems: 3 >> + resets: >> + minItems: 3 >> + >> +additionalProperties: true >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + sata@70020000 { >> + compatible = "nvidia,tegra210-ahci"; >> + reg = <0x0 0x70027000 0x0 0x00002000>, /* AHCI */ >> + <0x0 0x70020000 0x0 0x00007000>, /* SATA */ >> + <0x0 0x70001100 0x0 0x00010000>; /* SATA AUX */ > The default sizes are 1 cell for address and size, so this will give > you warnings. You either need to adjust the entries here or add a > parent node setting the sizes to 2 cells. Thanks Rob. tegra210.dtsi already has address and size set to 2 cells in parent node of sata. Do you mean to add parent node and address and size cells set to 2 in this yaml example as well? > >> + interrupts = ; > The error is because you need the include files for these defines. Will add header file for interrupts in yaml example. > >> + clocks = <&tegra_car TEGRA210_CLK_SATA>, >> + <&tegra_car TEGRA210_CLK_SATA_OOB>; >> + clock-names = "sata", "sata-oob"; >> + resets = <&tegra_car 124>, >> + <&tegra_car 129>, >> + <&tegra_car 123>; >> + reset-names = "sata", "sata-cold", "sata-oob"; >> + };