Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1099050pxu; Mon, 23 Nov 2020 11:35:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7UJlqaG9gik6pCVRSPJsN1Ti1etw2YXg2zy++9fqMNt/0ze6Mgiad8vtGZlVw5N7Q1mLr X-Received: by 2002:a17:906:b2cf:: with SMTP id cf15mr1061074ejb.525.1606160144010; Mon, 23 Nov 2020 11:35:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606160143; cv=none; d=google.com; s=arc-20160816; b=nWaITZKt5NWJOBFzKHPzaFoE1GflCxqqbtsgXrZOzsxcicEVptOvHOFcCzdSd08vSC IHKxY3doghVdOzECBPvB5Qsrp3JJtDGi8tFwMyBDuJMQOikjQvWPTn/8Pnu5UJZpK/l3 3SgCFFh9mU4mx5X+GDvUcFsULUcvSI6ByFMlRq+s7G67aNShfr5J1bHPXudIKqB39KZ2 6Rf9NIUR5uqEHjH+oBmJsEXOyXGQJErU8o3g4vhoNYsjmvPYGhVegBCra7yqXkxxYh23 teuHMsdaGac5Dz+yUDzgBKVbWr5Fn2ZT9l7r7J/olef6Jc/FNYG0fLAMhc37tshWCDbY 7hdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/oxcQlFvwWpMO7fHpsQkvXcJ00SFmanYy3+AbiRDOhQ=; b=BiJfWgbeFyx5QwO6NbhKIjzVpvhWOaaLJKcftCUmnpWwYSoSdsEYVvubgyUUAWYuin QmKw7p/Fhjgd9RTXBG/pDgOh1kwc/BodeLPypNEDaIkpnd1QgG5iI0/8BTB1xhW3bgSU 8oAehA92wbzHK6b1wnbIzFTUPVUp2mV7VldwN9lmkOAHlMsvg8rvwdy8Y/VA18nv+7Dp 1YgO0gU4FazTUx5bV0qWig5GiWxkd24YcFfKPEdmi5U1KBZx/jKqmrhRwIhhX/72e9fH U8yR9ko75gU07L3Sese//wv7rOfbjFC4Q9YmOPEoUh4656i3D8dtrX61EVwGlhb/C3aB kysQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si7342629edn.152.2020.11.23.11.35.20; Mon, 23 Nov 2020 11:35:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730397AbgKWTcw (ORCPT + 99 others); Mon, 23 Nov 2020 14:32:52 -0500 Received: from foss.arm.com ([217.140.110.172]:38780 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729595AbgKWTcv (ORCPT ); Mon, 23 Nov 2020 14:32:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97DE4101E; Mon, 23 Nov 2020 11:32:50 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.27.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDCC93F71F; Mon, 23 Nov 2020 11:32:46 -0800 (PST) Date: Mon, 23 Nov 2020 19:32:41 +0000 From: Mark Rutland To: Marco Elver Cc: Will Deacon , "Paul E. McKenney" , Steven Rostedt , Anders Roxell , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Jann Horn , Linux Kernel Mailing List , Linux-MM , kasan-dev , rcu@vger.kernel.org, Peter Zijlstra , Tejun Heo , Lai Jiangshan , linux-arm-kernel@lists.infradead.org Subject: Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...) Message-ID: <20201123193241.GA45639@C02TD0UTHF1T.local> References: <20201118233841.GS1437@paulmck-ThinkPad-P72> <20201119125357.GA2084963@elver.google.com> <20201119151409.GU1437@paulmck-ThinkPad-P72> <20201119170259.GA2134472@elver.google.com> <20201119184854.GY1437@paulmck-ThinkPad-P72> <20201119193819.GA2601289@elver.google.com> <20201119213512.GB1437@paulmck-ThinkPad-P72> <20201119225352.GA5251@willie-the-truck> <20201120103031.GB2328@C02TD0UTHF1T.local> <20201120140332.GA3120165@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120140332.GA3120165@elver.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 03:03:32PM +0100, Marco Elver wrote: > On Fri, Nov 20, 2020 at 10:30AM +0000, Mark Rutland wrote: > > On Thu, Nov 19, 2020 at 10:53:53PM +0000, Will Deacon wrote: > > > FWIW, arm64 is known broken wrt lockdep and irq tracing atm. Mark has been > > > looking at that and I think he is close to having something workable. > > > > > > Mark -- is there anything Marco and Paul can try out? > > > > I initially traced some issues back to commit: > > > > 044d0d6de9f50192 ("lockdep: Only trace IRQ edges") > > > > ... and that change of semantic could cause us to miss edges in some > > cases, but IIUC mostly where we haven't done the right thing in > > exception entry/return. > > > > I don't think my patches address this case yet, but my WIP (currently > > just fixing user<->kernel transitions) is at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/irq-fixes > > > > I'm looking into the kernel<->kernel transitions now, and I know that we > > mess up RCU management for a small window around arch_cpu_idle, but it's > > not immediately clear to me if either of those cases could cause this > > report. > > Thank you -- I tried your irq-fixes, however that didn't seem to fix the > problem (still get warnings and then a panic). :-/ I've just updated that branch with a new version which I hope covers kernel<->kernel transitions too. If you get a chance, would you mind giving that a spin? The HEAD commit should be: a51334f033f8ee88 ("HACK: check IRQ tracing has RCU watching") Otherwise, I intend to clean that up and post it tomorrow (without the additional debug hacks). I've thrown my local Syzkaller instance at it in the mean time (and if I get the chance tomrrow I'll try to get rcutorture setup), and the only report I'm seeing so far looks genuine: | BUG: sleeping function called from invalid context in sta_info_move_state ... as that was reported on x86 too, per: https://syzkaller.appspot.com/bug?id=6c7899acf008be2ddcddb46a2567c2153193632a Thanks, Mark.