Subject: Re: [PATCH] Pass sparse the lock expression given to lock
	annotations
From: Josh Triplett <josht@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20060825104632.df1fd26b.akpm@osdl.org>
References: <1156466936.3418.58.camel@josh-work.beaverton.ibm.com>
	 <20060824210531.6264f285.akpm@osdl.org>
	 <1156521234.3420.19.camel@josh-work.beaverton.ibm.com>
	 <20060825104632.df1fd26b.akpm@osdl.org>
Content-Type: text/plain
Date: Fri, 25 Aug 2006 11:21:58 -0700
Message-Id: <1156530118.19291.4.camel@josh-work.beaverton.ibm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2003
Lines: 45

On Fri, 2006-08-25 at 10:46 -0700, Andrew Morton wrote:
> On Fri, 25 Aug 2006 08:53:53 -0700
> Josh Triplett <josht@us.ibm.com> wrote:
> 
> > On Thu, 2006-08-24 at 21:05 -0700, Andrew Morton wrote:
> > > On Thu, 24 Aug 2006 17:48:56 -0700
> > > Josh Triplett <josht@us.ibm.com> wrote:
> > > 
> > > > The lock annotation macros __acquires, __releases, __acquire, and __release
> > > > all currently throw the lock expression passed as an argument.  Now that
> > > > sparse can parse __context__ and __attribute__((context)) with a context
> > > > expression, pass the lock expression down to sparse as the context expression.
> > > 
> > > What is the dependency relationship between your kernel changes and your
> > > proposed change to sparse?
> > 
> > Sparse with my multi-context patch will continue to parse versions of
> > the kernel without this kernel patch, since I made the context
> > expression optional in sparse.  Versions of sparse without my
> > multi-context patch will not parse kernels with this kernel patch (since
> > previous versions of sparse will not support the extra argument).
> 
> OK.  Is this patch the only one which will break current sparse versions? 
> If not, please identify the others.

Only this patch will break current sparse versions.

> I'll keep the non-back-compatible kernel patches in -mm until you've
> informed me that a suitable version of sparse has been released.  Then we
> can include that sparse version number in the kernel changelogs so things
> are nice and organised.

Sounds good.  Since sparse doesn't really have "releases", just the
kernel.org GIT tree, I'll let you know when it gets committed and supply
an updated patch with the appropriate GIT revision in the commit
message.

- Josh Triplett


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/