Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1180768pxu; Mon, 23 Nov 2020 13:51:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSPp7g0z/rU0GQH57ExEbtDACzEYOFbRZoIJ7nt249N+QoRcklZwfUVhxu57rt+LiDSS+L X-Received: by 2002:a17:906:3687:: with SMTP id a7mr1494561ejc.210.1606168281078; Mon, 23 Nov 2020 13:51:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606168281; cv=none; d=google.com; s=arc-20160816; b=lKCQpOeDbcr80YZbO6lkkRqlwDqYSNvtBodtWK4arDc3iBLN0DClbMOBZSa9t14+I8 S8TZu8b0WybIeA9BqGmyidrjPpQJmY7trzHqc4AAaG/DDVSYTpCtcmMFP83IzSCxg9FL xuvUWI2hVjDYIE/CqpV5N5laAHD7RLBzrqT3bTZfmwsGMfRJ7ObeDsPyXJ7Fj1hEXCIz ASTamOGQ/+OOz+L2QewmwCJ0h/8OCx/e0vSaaxKrnK/nHB72ZX/S+iVxS4jjUMHxOnbt EmiQFGWu4mLItqsicCOVotlGQKPs9juykbu1ot93EtxW3pwRyfZNuusixI8EbpBwnkjL 1gHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=jkD2Rx8S6Zh+nTAuoem26SPIQZfP+CAg7v8KnEN9CIt9cnrspUuR09z1IuMUEVBMpH nhcH+vnQxKxNeiqy6+Biql5sbgnwRVyjUOeUC5aq06uj7ofNHNUjkku4XAkjEwtS67YR wu+4olfk/V4gnwpHQ+nJPYxtiNvpNatKbCLxnhxzskDbahGx/a7EDM2/yKRs+0RVApdf PgcQ6TST3Vgm3Np7EvIR13o4Ln219EKo1k6cOsjHG6WCC2w/lTeyAPD9zG1JR/EmRknd CeuY93MscjpDv3COT8tLxMzrZC9+h2XWpNiExqHLRnpjp0Cnge8yrqkHTv03YcHKevDa UcaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YcNnH80O; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si7271003ejk.90.2020.11.23.13.50.58; Mon, 23 Nov 2020 13:51:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YcNnH80O; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731876AbgKWVsE (ORCPT + 99 others); Mon, 23 Nov 2020 16:48:04 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:38558 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730108AbgKWVsE (ORCPT ); Mon, 23 Nov 2020 16:48:04 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=YcNnH80Owhk67icq+BuAaMvftswTwmhM+6euUdaRP7WH3T+rzPpJstyMnAnylH/NUwzqUo ZQrS0RmAPYvBjjLnr4LpGTm8v0sSlD18iq5nCw2lZx3WXOpAS63Tp+BfZtPdNM1BD34108 VYnzKJh/bF9SujydFoFCIzQwqCgIgfLg4x+BX4gNkGtjk3nOeaPEpSeeJw6e9WybLoupX3 m5NVmypPWg1ykY9tZ+MmwxOcGBWUa2LBVQwce5TSLeeJ5Ny1hRHS4DTFHrKRmCX+TsDn+4 cq1ml6AdNowL6NbKTl1jWudmP4lGWwmBUrYSykWVmMgRuDWnvIQdK+hmUDGWGA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=mMt/hU8u/OTPxDuQKILiP1HhdRxZ4zvs1L8KKoZmzhLl6g612jVzcISf+J/GJPD6Y6RT8s rYLoGs+JkPIjWpCA== To: Alex Belits , "nitesh\@redhat.com" , "frederic\@kernel.org" Cc: Prasun Kapoor , "linux-api\@vger.kernel.org" , "davem\@davemloft.net" , "trix\@redhat.com" , "mingo\@kernel.org" , "catalin.marinas\@arm.com" , "rostedt\@goodmis.org" , "linux-kernel\@vger.kernel.org" , "peterx\@redhat.com" , "linux-arch\@vger.kernel.org" , "mtosatti\@redhat.com" , "will\@kernel.org" , "peterz\@infradead.org" , "leon\@sidebranch.com" , "linux-arm-kernel\@lists.infradead.org" , "pauld\@redhat.com" , "netdev\@vger.kernel.org" Subject: Re: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function In-Reply-To: <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> Date: Mon, 23 Nov 2020 22:48:01 +0100 Message-ID: <87eekjn3se.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: why are you insisting on adding 'task_isolation: ' as prefix to every single patch? That's wrong as I explained before. The prefix denotes the affected subsystem and 'task_isolation' is _NOT_ a subsystem. It's the project name you are using but the affected code belongs to the memory management subsystem and if you run git log mm/vmstat.c you might get a hint what the proper prefix is, i.e. 'mm/vmstat: ' > In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") > the quiet_vmstat() function became asynchronous, in the sense that > the vmstat work was still scheduled to run on the core when the > function returned. For task isolation, we need a synchronous This changelog is useless because how should someone not familiar with the term 'task isolation' figure out what that means? It's not the reviewers job to figure that out. Again: Go read and adhere to Documentation/process/* Aside of that your patches are CR/LF inflicted. Please fix your work flow and tools. Thanks, tglx