Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 23 Nov 2020 23:26:59 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 22/24] perf buildid-cache: Add --debuginfod option
Message-ID: <20201123222659.GA2088148@krava>
References: <20201109215415.400153-1-jolsa@kernel.org>
 <20201109215415.400153-23-jolsa@kernel.org>
 <CAP-5=fUDtTU2XYr6w6wYndP6RVFDLoJSnC31m+djA-r9EVMQiw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fUDtTU2XYr6w6wYndP6RVFDLoJSnC31m+djA-r9EVMQiw@mail.gmail.com>
Precedence: bulk

On Thu, Nov 19, 2020 at 12:23:53PM -0800, Ian Rogers wrote:
> On Mon, Nov 9, 2020 at 1:55 PM Jiri Olsa <jolsa@kernel.org> wrote:
> 
> > Adding --debuginfod option to specify debuginfod url and
> > support to do that through config file as well.
> >
> > Use following in ~/.perfconfig file:
> >
> >   [buildid-cache]
> >   debuginfod=http://192.168.122.174:8002
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  .../perf/Documentation/perf-buildid-cache.txt |  4 +++
> >  tools/perf/builtin-buildid-cache.c            | 28 +++++++++++++++++--
> >  2 files changed, 29 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/perf-buildid-cache.txt
> > b/tools/perf/Documentation/perf-buildid-cache.txt
> > index b77da5138bca..0152d8b5cfbe 100644
> > --- a/tools/perf/Documentation/perf-buildid-cache.txt
> > +++ b/tools/perf/Documentation/perf-buildid-cache.txt
> > @@ -84,6 +84,10 @@ OPTIONS
> >         used when creating a uprobe for a process that resides in a
> >         different mount namespace from the perf(1) utility.
> >
> > +--debuginfod=URL::
> > +       Specify debuginfod URL to be used when retrieving perf.data
> > binaries,
> > +       it follows the same syntax as the DEBUGINFOD_URLS variable.
> > +
> >
> 
> Acked-by: Ian Rogers <irogers@google.com>
> 
> Nit: the environment variable name hints at this being a list, perhaps
> change URL:: above to URLs:: to keep this clear.

true, will change that

thanks,
jirka