To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
References: <1a41dc627c5a1bc2f7e9.1156530287@eng-12.pathscale.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Fri, 25 Aug 2006 12:35:06 -0700
In-Reply-To: <1a41dc627c5a1bc2f7e9.1156530287@eng-12.pathscale.com> (Bryan O'Sullivan's message of "Fri, 25 Aug 2006 11:24:47 -0700")
Message-ID: <adafyfktxqt.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 17

1) What makes ipath special so that we want this warning for ipath
devices but not other IB hardware?  If this warning is actually
useful, then I think it would make more sense to start a timer when
any IB device is added, and warn if ports with a physical link don't
become active after the timeout time.  But I'm having a hard time
seeing why we want this message in the kernel log.

2) You do cancel_delayed_work() but not flush_scheduled_work(), so
it's possible for your timeout function to be running after the module
text is gone.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/