Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1237225pxu; Mon, 23 Nov 2020 15:34:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5SD5dykUoRr5KV0QUiH9MiLZbIizqiPMwl5qrkGX/38zYtg047op73w1KEjmQOIcGfbQZ X-Received: by 2002:a17:906:48c1:: with SMTP id d1mr1791845ejt.123.1606174488980; Mon, 23 Nov 2020 15:34:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606174488; cv=none; d=google.com; s=arc-20160816; b=gE1lz6VBC53k93ICNa9IQ9eYwd18B17BLalvvV0TWbcXaTqvFKjWYqxMNm1HACQl+/ fVeeTGMIcxAWyGwnnBgBwc98I7hdrfn5GfjtLO5afObMWFdMaFszuobx+kllucFwXiTu cnL3ICtM1DssVINsxuO1T05kFO/NTLV6XbBv3CRmi6dkZTNzxJhVBXeoySObHjyznWSA 9JYOsNMzxZogobrJRuIxCK/icVJQKfg8wRoz6agsJO7Yr+SPWhRIfX7Ir3uor6Niibtm ObcKpMh91x3LqJAEpIIff/Rx88tKyNLgnEI1KzLXQ9ysJtp+7mbvevQF/2SCZ/xQ6zXm mnJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P3of7GjEbwitk/MGumGrACGWJyov8p+sEJdWaW450vc=; b=VZ6dUbX/cdezOUTBhfaJVTYt/oyerUGy5eSJONOUi+rdCgmbk+PDbIAQAYprHsW9eR BUthBcvf4PT/Z8bnUhJh2EGVYI3Ifa1HMu2oId03WjmFk4owmlXJIaDRplIax7X/GoCp E2GBaoeDcCKRLsXD+Jpi7G5jHsrmkDXaYhCgoFFIp1fk3nC6f3pHgo4sv/XWV2c1qAsq 7dqUKTNS4KMGP83/xRLOS8ommevhdwd4P+c+ZYwcDKUjCl/ESfTOuIrNIq7YqsafFDJM UF8c9JnXFIBqk6XPBc4Um6n+mlY13P9zidN7G4ext+0ejA1JeN9CAKdW/fgjjhyraCfT qxcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fmZ2P48r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn5si8491346ejc.533.2020.11.23.15.34.26; Mon, 23 Nov 2020 15:34:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fmZ2P48r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730841AbgKWMbU (ORCPT + 99 others); Mon, 23 Nov 2020 07:31:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:42060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730825AbgKWMbN (ORCPT ); Mon, 23 Nov 2020 07:31:13 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB5F020781; Mon, 23 Nov 2020 12:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606134671; bh=xlLfugiOHGGKEEAfOJDqFe3YxwH0PwHIuzYn3TTu5Lw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fmZ2P48rqwTBqyCsTnm7JmTw6ltDyuUQl7DG07kYRutJcLpGRZd2eB+RdHQ4f8lRI 1U9tpxAxptRyZvvcu1W1jkZujFIEWM7JrOzP0kJz0EtEbb4S0yz6dOEdBNs01bUgAf aVBWx2bIOgTA9GTmf+PP6h289dJSGM8xDM985Pi0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heiner Kallweit , Jakub Kicinski Subject: [PATCH 4.19 10/91] net: bridge: add missing counters to ndo_get_stats64 callback Date: Mon, 23 Nov 2020 13:21:30 +0100 Message-Id: <20201123121809.801456175@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201123121809.285416732@linuxfoundation.org> References: <20201123121809.285416732@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit 7a30ecc9237681bb125cbd30eee92bef7e86293d ] In br_forward.c and br_input.c fields dev->stats.tx_dropped and dev->stats.multicast are populated, but they are ignored in ndo_get_stats64. Fixes: 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches") Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/58ea9963-77ad-a7cf-8dfd-fc95ab95f606@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_device.c | 1 + 1 file changed, 1 insertion(+) --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -215,6 +215,7 @@ static void br_get_stats64(struct net_de sum.rx_packets += tmp.rx_packets; } + netdev_stats_to_stats64(stats, &dev->stats); stats->tx_bytes = sum.tx_bytes; stats->tx_packets = sum.tx_packets; stats->rx_bytes = sum.rx_bytes;