Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1237968pxu; Mon, 23 Nov 2020 15:35:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvVBSHx8GKddBt2HulAJMkt3lo2AJvxMwN4Rm/qig4olaOYvAUsgprkGho+hVDctnwwKbB X-Received: by 2002:a17:907:262d:: with SMTP id aq13mr1825342ejc.484.1606174559549; Mon, 23 Nov 2020 15:35:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606174559; cv=none; d=google.com; s=arc-20160816; b=KgGJRnmH6rYvH/LV4P1SVNKRnAPmTAtwpqwgNkwqErQtFfIcevSS8vKIj5DcJiUk+G Lyd/LnjULo3RkwgPy3wfUm4lmAUqAxOfVnLuppF3jYmyVdjW6ijSVTAtvwlp2w0KhCnu kccCNQC5cLMqW+JJLNZX93emMGdygZC7itQ4HqwXTHQ/POeuaV8WXhFHObSSUuNUXBiC 8V2uDgyRlkBLh9mdBRBeob2zMyPWLIQN452EJKmmyZ3IHU56zF8esjuS57FaAMFqfuGi GaFN0Fi8oMCOTgZfeaqsjsLBbOhWCDDJwNwtHep4jqsZItGEuFYzXAKzzrZVO1dxCJ4U aMZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LRfqoOSuB1zFsHR6OLX4YQihQ/mvnPnbLR8OOxZ+s8M=; b=VcLxgGfOjSQl38ZrL+TlTIUFuVxF3BnRqhC5dYWHk23nEQEFKupfZd1VFc60vmsDDV OXr6A7hwPcB0lQ1szRvCubJQDlteHoLPfQiHgxj1NnrEajJ5cegvjUyr2YH6By7RAQ0H K+byGXewVcfX/beT/QcI+VdL4rjgu9HIHBrgNr8+P8W1uyW4i1FKtklWQyc2yV2kxKh3 WlGoPnueGADgY3UmbebQKjjLtgumuav1H7MX8opgHVSaReOstXf4v9yc2ICwZGdrIGfG 78Im0hNsqFQbuzjl+AvgoJlQdCgmK/s1lprnY/4cYHjR2356YoT07S1XYmGsGhwH89Vd 4e4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HLAg1xGM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si8798974eji.62.2020.11.23.15.35.37; Mon, 23 Nov 2020 15:35:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HLAg1xGM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731322AbgKWMeJ (ORCPT + 99 others); Mon, 23 Nov 2020 07:34:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:45818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731311AbgKWMeH (ORCPT ); Mon, 23 Nov 2020 07:34:07 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF61F20857; Mon, 23 Nov 2020 12:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606134847; bh=VMUCacP5KWIt2BnE2bLlvWelK0TuHa92mu+lGhZniEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HLAg1xGMDspY0+qKUIF90YE63dDElYFaLTdu1/kEk11vKsT2WMSYjFANQR4RGsIDO 7UcVU6TNgrncv1iEYLTDO0mTIYXNtlldQb5azMvrwzBis3eO3mWyhpsf6IZEOm2AY/ /rY/MonBLDLH0tGMGOkYGGd1V9vrS6djekHzNkLU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heiner Kallweit , Jakub Kicinski Subject: [PATCH 5.4 012/158] net: bridge: add missing counters to ndo_get_stats64 callback Date: Mon, 23 Nov 2020 13:20:40 +0100 Message-Id: <20201123121820.534887667@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201123121819.943135899@linuxfoundation.org> References: <20201123121819.943135899@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit 7a30ecc9237681bb125cbd30eee92bef7e86293d ] In br_forward.c and br_input.c fields dev->stats.tx_dropped and dev->stats.multicast are populated, but they are ignored in ndo_get_stats64. Fixes: 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches") Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/58ea9963-77ad-a7cf-8dfd-fc95ab95f606@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_device.c | 1 + 1 file changed, 1 insertion(+) --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -214,6 +214,7 @@ static void br_get_stats64(struct net_de sum.rx_packets += tmp.rx_packets; } + netdev_stats_to_stats64(stats, &dev->stats); stats->tx_bytes = sum.tx_bytes; stats->tx_packets = sum.tx_packets; stats->rx_bytes = sum.rx_bytes;