Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1267829pxu; Mon, 23 Nov 2020 16:32:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyt+TBNV8loEHakPu79HhBqMofSCciazBgOwHlTdNhOCAfAYl9u31e4ILMjqp6ZnMg+lyHj X-Received: by 2002:a17:907:2043:: with SMTP id pg3mr2008155ejb.95.1606177931886; Mon, 23 Nov 2020 16:32:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606177931; cv=none; d=google.com; s=arc-20160816; b=hAADzkSXf0k494mkcpiphBR8MTdkKZ6Pse6VLluEI9t9WQBq8DfFXxj2p+ocNuUj8B 2tSoDsNt9D/Tpr7zmcvI2/3YpgpdwHL2/lN2KXGs8EbU470z/IDpjM1RYBybABcbXaRG zA0GOGWmwh9RvPwQtqurYsBBhSCgPYq70LghnQnrnXhJmgNdy/j3z9eh74uTJ83MTfkn W9lQmNgcZuNlowF1cT8b+wmUzkgPsb9AE+s+9rr24rjZYvUhqCt+CHyRzb5dgxA3Fl5U ZmE9HctYa/bCrISBN1IIcWgnmLI+TUK8IKeFKXkmFGtxGKVObil4bHOJbAvc6DL1EQO+ f3fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ypQOivTTwdFzb+/3Z+R/AYhQITc/BOXMPX6lQujmA4Y=; b=lBftnB20EsPjfKE41RB+lH667shhRtm5PAgCS/OF34tmJIEo9sWng05oG4+cF/gp8Y QiE2R1KHpVe3qLXcMVdobVXUjf97wr149oQAVfrGv1vidpOf0AbPqkHNTPPnwqkQzkLe trwYU0Dc4Wdva2duClFVyxGrNa3ZqlT07jNtFriyQvSUznSB6r6oRtO2h20jhJZLlqBA Fz/gr56+NgacoX0z/A6gnH4Q1zr2Y2CXvI1asDNvLwBelLlsjOgU7BhAu+T8af2oZD9I 9M/FMJ0fib48NeoCKxxQNqz5P1qKYByqB1CQM8lciXyRZqrGfKNHsx6UWIt9KCpoTXG6 wY+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=UboGT20O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si8359717eds.434.2020.11.23.16.31.49; Mon, 23 Nov 2020 16:32:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=UboGT20O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732510AbgKWOyZ (ORCPT + 99 others); Mon, 23 Nov 2020 09:54:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732043AbgKWOyZ (ORCPT ); Mon, 23 Nov 2020 09:54:25 -0500 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21AB0C061A4D for ; Mon, 23 Nov 2020 06:54:25 -0800 (PST) Received: by mail-oo1-xc42.google.com with SMTP id r11so3990497oos.12 for ; Mon, 23 Nov 2020 06:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ypQOivTTwdFzb+/3Z+R/AYhQITc/BOXMPX6lQujmA4Y=; b=UboGT20Ox8squh3d2ZnQggVw2BtXqKOdT/s+tMz0g3csU8VHrONyW5B1YMIwVnvOpJ BVhxs2al+NwQ7/SMb4AlCm1HMMGJIkJ4dUHbEsfPSfhv/PIufUJTEUVTBAPFNlUKZ9Zi VKFmopTXQh23vKUrupe0vcmMB14nl3Hn7cotKcM8aBbzk456BuyKe5yx9hTMYsX63paI 4j7Ui6K4z4tm29cT38tR4eWypwKe4Xidf2ELMd1Qpxa2/nRlkTKR0TWiestlDZlqI08W sKPIQQJFrEgp6sIsBBB9itZyqPLE01pGzbEgFzuhnLBxKeAzPwL09o/fP2akKmeTbh+d TzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ypQOivTTwdFzb+/3Z+R/AYhQITc/BOXMPX6lQujmA4Y=; b=nThiudDII45sz68x89u5pjyfZ+XylSL4l/srlJzvralQPHOf5hq75iXTi5X4vNzWvZ 2BR1a4HrymIzvELka6I2P05anvBZeF4e1exwmHfKExEMFlrMexasUxq1Uh2dAOPpxQV3 RWPlvKKRlZav57c6pA/M6brBNauIr8zXOPuUS4suGhc4bHfIM93yvTwlM9ARP7z6E/qF /WpzZF/r286C/U72HGQL0T5Y6VQZ7BNAwopNjNoZTXctrafhJKc2ift1fHwmmMeQHqD6 lqf32WwFpCMLlOZo3aCyT5kDaiXxbEasEvzqPpim6uV4Qr21ohr0/fsY1XNUYyLOCJyF QZAA== X-Gm-Message-State: AOAM530PCqYFXkM+uDSNU1xdEkiWyVIj1WdHYXgPlcQBnk4JbJblJJn4 HxrrdSEj41y7aw7YXQkbmUZekA== X-Received: by 2002:a4a:eac1:: with SMTP id s1mr23273490ooh.15.1606143264324; Mon, 23 Nov 2020 06:54:24 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:acac:b2ef:c7d:fd8a]) by smtp.gmail.com with ESMTPSA id 43sm6858710otf.28.2020.11.23.06.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 06:54:23 -0800 (PST) Date: Mon, 23 Nov 2020 14:54:20 +0000 From: David Brazdil To: Quentin Perret Cc: Catalin Marinas , Will Deacon , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Rob Herring , Frank Rowand , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" , kernel-team@android.com, android-kvm@google.com Subject: Re: [RFC PATCH 09/27] KVM: arm64: Allow using kvm_nvhe_sym() in hyp code Message-ID: <20201123145420.hjl24xp6p2nn26u2@google.com> References: <20201117181607.1761516-1-qperret@google.com> <20201117181607.1761516-10-qperret@google.com> <20201123125723.4mnodg3tnal4q4v2@google.com> <20201123140250.GB490744@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123140250.GB490744@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2020 at 02:02:50PM +0000, 'Quentin Perret' via kernel-team wrote: > On Monday 23 Nov 2020 at 12:57:23 (+0000), David Brazdil wrote: > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > > index 882eb383bd75..391cf6753a13 100644 > > > --- a/arch/arm64/kvm/arm.c > > > +++ b/arch/arm64/kvm/arm.c > > > @@ -1369,7 +1369,7 @@ static void cpu_prepare_hyp_mode(int cpu) > > > > > > params->vector_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref(__kvm_hyp_host_vector)); > > > params->stack_hyp_va = kern_hyp_va(per_cpu(kvm_arm_hyp_stack_page, cpu) + PAGE_SIZE); > > > - params->entry_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref(__kvm_hyp_psci_cpu_entry)); > > > + params->entry_hyp_va = kern_hyp_va((unsigned long)kvm_ksym_ref_nvhe(__kvm_hyp_psci_cpu_entry)); > > > > Why is this change needed? > > You mean this line specifically or the whole __kvm_hyp_psci_cpu_entry > thing? > > For the latter, it is to avoid having the compiler complain about > __kvm_hyp_psci_cpu_entry being re-defined as a different symbol. If > there is a better way to solve this problem I'm happy to change it -- I > must admit I got a little confused with the namespacing along the way. Yeah, we do need a more robust approach. It's getting out of control. > > Thanks, > Quentin > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >