Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <735253bd-5500-2b8d-c98d-99bddb0617ce@web.de>
In-Reply-To: <735253bd-5500-2b8d-c98d-99bddb0617ce@web.de>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 24 Nov 2020 00:27:02 +0100
Message-ID: <CACRpkdb4+av1sDrQHYXYeyKemnm2a9PFGQbu++UHEe6sspRACQ@mail.gmail.com>
Subject: Re: [Regression]: Commit 74d905d2 breaks the touchpad and touchscreen
 of Google Chromebook "samus"
To:     Andre <andre.muller@web.de>
Cc:     Nick Dyer <nick.dyer@itdev.co.uk>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "George G. Davis" <george_davis@mentor.com>,
        Jiada Wang <jiada_wang@mentor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 4, 2020 at 9:18 AM Andre <andre.muller@web.de> wrote:

> commit 74d905d2: Input: atmel_mxt_ts - only read messages in
> mxt_acquire_irq() when necessary
>
> breaks the touchpad and touchscreen of the 2015 Chromebook Pixel "Samus".

This commit also breaks the touchscreen on the Samsung GT-I9070
mobile phone. All interrupts stop appearing. If I revert the patch
I get interrupts.

dmesg after this commit:

$ dmesg |grep mxt
[    1.967816] atmel_mxt_ts 3-004a: Family: 129 Variant: 1 Firmware
V1.0.AA Objects: 18
[    1.975815] atmel_mxt_ts 3-004a: Enabling RETRIGEN workaround
[    1.982398] atmel_mxt_ts 3-004a: Direct firmware load for
maxtouch.cfg failed with error -2
[    1.992252] atmel_mxt_ts 3-004a: Touchscreen size X479Y799

dmesg with commit reverted:
$ dmesg |grep mxt
[    1.967831] atmel_mxt_ts 3-004a: Family: 129 Variant: 1 Firmware
V1.0.AA Objects: 18
[    1.984195] atmel_mxt_ts 3-004a: Direct firmware load for
maxtouch.cfg failed with error -2
[    2.007399] atmel_mxt_ts 3-004a: Touchscreen size X479Y799

And I get interrupts.

Tell me if I need to test some more approaches.

Yours,
Linus Walleij