Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422880AbWHYTvF (ORCPT ); Fri, 25 Aug 2006 15:51:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422865AbWHYTvF (ORCPT ); Fri, 25 Aug 2006 15:51:05 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:50207 "EHLO sj-iport-6.cisco.com") by vger.kernel.org with ESMTP id S1422880AbWHYTvC (ORCPT ); Fri, 25 Aug 2006 15:51:02 -0400 To: "Bryan O'Sullivan" Cc: openib-general@openib.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11 of 23] IB/ipath - add new minor device to allow sending of diag packets X-Message-Flag: Warning: May contain useful information References: <8743e6ee09c51e799f0f.1156530276@eng-12.pathscale.com> From: Roland Dreier Date: Fri, 25 Aug 2006 12:50:58 -0700 In-Reply-To: <8743e6ee09c51e799f0f.1156530276@eng-12.pathscale.com> (Bryan O'Sullivan's message of "Fri, 25 Aug 2006 11:24:36 -0700") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 25 Aug 2006 19:51:01.0084 (UTC) FILETIME=[CA8651C0:01C6C87F] Authentication-Results: sj-dkim-1.cisco.com; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com verified; ); Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 18 > + if (ret < 0) { > + printk(KERN_ERR IPATH_DRV_NAME ": Unable to create " > + "diag data device: error %d\n", -ret); > + goto bail_ipathfs; > + } > + The last line adds trailing whitespace, which git complains about. When patchbombing, can you run your patches through "git apply --check --whitespace=error-all" or the equivalent? Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/