Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1356183pxu; Mon, 23 Nov 2020 20:00:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyceoRWkxCL6JiIBI/iwIam6AVqwD/sNfxhN/sAM1613+/ddhrWzj8L3GIIQRYpD/FOFOw+ X-Received: by 2002:a17:906:12cf:: with SMTP id l15mr2617788ejb.540.1606190405887; Mon, 23 Nov 2020 20:00:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606190405; cv=none; d=google.com; s=arc-20160816; b=Fp7jQd6Ltf5n+MWg7CKxTYQBIGDvHFVlZHGyy+BDyScubfRaYtX3Bv0rCl22xgqjah /sSOEscGZDm5rRhkiiNvhP9jriDXtT4qLcsjEs1Rc8y/9OHyIp4juiLeYfbHXFecQYUb Pb0hVbqaSTM7GLvXMg3qUEmMcchKhB+vxQLZMwMmGxwqy3cHtOAKAER65PNkQHMzBOt6 Gevm/TfSGhW2jirjc46WncHYJ4OvCDkuODQnEvmTW7iH9SNLizKcED29oYunbHK/qFgd 50kdBMjH/FV74CzPm/0evKf2ql839COUQDJYPrZYPYRW/NDLiQ6qBwgQ64hWbGcoc/I7 kHBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/ZLENeEnN2+0E1PCxRwxG5g88lZ4hV6KzJ9wcqHyiEc=; b=tZnHbk1UIVCpd8JXwS3wbHugSvyVPBpoYueKlqcmmarbYXROax9EdfOT8hNXXUbkgx 71oIK+qWOXpI5+HQIc8vvYkyZU3THCqcD0p8HVsf7hmKLKoTuS9GPuRXbLb584ut2Yjj QuWFAYOWbv+kE8FMbUcE/JFwmE0Xcg3hSFjS8wadHyiY+XF6s+JXHTlbv5laDVjCBtaG bG0idoE4RSLk6s/Fau6DhfJ+NiMr4ygzYTFBp62u7FEeaxwJtKPAAdEx7qvypSJFRt33 XY5uhfx8RbS8LyGLx7e07deQCXZH8Cxb/WyDSo53g7xFDSq1IiMUhIFWfjhJIacrPhNx Ardg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=vP41p4Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm22si7969289edb.342.2020.11.23.19.59.43; Mon, 23 Nov 2020 20:00:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=vP41p4Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgKXD6U (ORCPT + 99 others); Mon, 23 Nov 2020 22:58:20 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:50500 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727869AbgKXD6T (ORCPT ); Mon, 23 Nov 2020 22:58:19 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AO3saNm090548; Tue, 24 Nov 2020 03:58:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=/ZLENeEnN2+0E1PCxRwxG5g88lZ4hV6KzJ9wcqHyiEc=; b=vP41p4Js/JD286n9Nno0u5Zwaih/AJYPAC0oHTzgAw/oNlzK0NxJyT9kI8nWNavYk2zC ccz9jTBeXGtjAe6VWPd0Mz9ftzUsRPyuiw1c1Cy3DVOS1Nokb9RX+JU6nGze6zV1fGF+ 61hQ5ujUM9I9jY6yiCOrtJBYJmFvk61Ifxw/x96s9S50ExiLUiHR61asmy327i+T3it3 c3I2mT3ooIkUGdHv5v9TmQbN3eAhmuJ+l2e6bp7Tb1PXhollUAXy0OdmzFgiTyNXnA8T iESzu25K2QkoCgCxWs6xzUUYrT7xGYbNo5h9WPlb10cuUx4dM6Fl7SOKsBwCpyRkIXvR bg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 34xrdarmbv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Nov 2020 03:58:14 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AO3twOf140274; Tue, 24 Nov 2020 03:58:14 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 34ycfmr826-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Nov 2020 03:58:14 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AO3wDtM006109; Tue, 24 Nov 2020 03:58:13 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 23 Nov 2020 19:58:12 -0800 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, James Smart , Colin King , "James E . J . Bottomley" , Dick Kennedy Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check Date: Mon, 23 Nov 2020 22:58:01 -0500 Message-Id: <160618683552.24173.9532956225953675883.b4-ty@oracle.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201118133744.461385-1-colin.king@canonical.com> References: <20201118133744.461385-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9814 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240021 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9814 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 phishscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240021 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020 13:37:44 +0000, Colin King wrote: > Currently there is a null check on the pointer ndlp that exits via > error path issue_ct_rsp_exit followed by another null check on the > same pointer that is almost identical to the previous null check > stanza and yet can never can be reached because the previous check > exited via issue_ct_rsp_exit. This is deadcode and can be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Remove dead code on second !ndlp check https://git.kernel.org/mkp/scsi/c/61795a5316ad -- Martin K. Petersen Oracle Linux Engineering