Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     "pawell@cadence.com" <pawell@cadence.com>,
        "balbi@kernel.org" <balbi@kernel.org>, "nm@ti.com" <nm@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: fix NULL pointer dereference on no platform
 data
Thread-Topic: [PATCH] usb: cdns3: fix NULL pointer dereference on no platform
 data
Thread-Index: AQHWwYZZgRghacfihUSnukQUanlqQqnW2K+A
Date:   Tue, 24 Nov 2020 06:49:27 +0000
Message-ID: <20201124064851.GB32310@b29397-desktop>
References: <20201123104931.2653-1-rogerq@ti.com>
In-Reply-To: <20201123104931.2653-1-rogerq@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DD146DB8D5E3F24290E0B96BBE4E26F7@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 209b05af-c73d-4057-ba3c-08d89045163d
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 06:49:27.2615
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1SZ4tJIFQtWyASmzAJBtkw+E+wN8AlcP25xU1cwSt2W/BA5rEfdZIeFH5ahHqLkqPpDOURyDPeRauaUU0FbwCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7817
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-11-23 12:49:31, Roger Quadros wrote:
> Some platforms (e.g. TI) will not have any platform data which will
> lead to NULL pointer dereference if we don't check for NULL pdata.
>=20
> Fixes: a284b7fd1b8f ("usb: cdns3: add quirk for enable runtime pm by defa=
ult")
> Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  drivers/usb/cdns3/core.c | 2 +-
>  drivers/usb/cdns3/host.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 54d841aa626f..0f08aebce86d 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -559,7 +559,7 @@ static int cdns3_probe(struct platform_device *pdev)
>  	device_set_wakeup_capable(dev, true);
>  	pm_runtime_set_active(dev);
>  	pm_runtime_enable(dev);
> -	if (!(cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLOW))
> +	if (!(cdns->pdata && (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_AL=
LOW)))
>  		pm_runtime_forbid(dev);
> =20
>  	/*
> diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> index 08103785a17a..ec89f2e5430f 100644
> --- a/drivers/usb/cdns3/host.c
> +++ b/drivers/usb/cdns3/host.c
> @@ -59,7 +59,7 @@ static int __cdns3_host_init(struct cdns3 *cdns)
>  		goto err1;
>  	}
> =20
> -	if (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLOW)
> +	if (cdns->pdata && (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLO=
W))
>  		cdns->xhci_plat_data->quirks |=3D XHCI_DEFAULT_PM_RUNTIME_ALLOW;
> =20
>  	ret =3D platform_device_add_data(xhci, cdns->xhci_plat_data,

Thanks for fixing it, already applied to -next tree.

--=20

Thanks,
Peter Chen=