Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1502197pxu;
        Tue, 24 Nov 2020 01:42:07 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxyQNfnCHvlouqvuGts6Iz8xAedrPkwgxOhmg8ULlXBwzhdlWQd5xD/0G945eT5R0ZH6WfG
X-Received: by 2002:a17:906:b80e:: with SMTP id dv14mr3178358ejb.528.1606210927638;
        Tue, 24 Nov 2020 01:42:07 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1606210927; cv=none;
        d=google.com; s=arc-20160816;
        b=VuhG/1eDad6jYj5JO2U8yYTrneSzjcUnW2end0x5kguO7cSIMdCWChHSqPK8TrJ1fZ
         aY6F4Pz9o3AQNaY55H6asCLrtRFiSuNfsuPA3HCIgT77kJPMIT9rDoGV0/MIgp86v5uT
         /OwSIsHlJRbI2nhOvmkTj9rj3C9l8OGZOAe3kRqgSbgki2UII3o57vLbRT0+byv0JPca
         N+8Yj77JyL0q0Ppg03insRLTD6C17OVPMMvq2ftsR9z73yCwC6KAtgJlipbOO0hnwk6w
         BFjBz9kSXt6o286ybvzGxexy3Nqa4LhgDwyiBoB0CRHE8fpqOnBq4H3R3wdDqIO6losd
         iUgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=erVBEbSZXU0xKU0/OCceptXO8BMpPV2CdOs+DwG0M+s=;
        b=UkbGq9vKhmWxmtl1L6Vz7Jqjhd9PW9yy7+3G2Rnk5RG4JQSUJoSDuqcGYzVc7zDfwW
         PqMmQg016wUvHCihQDp6Ph4aIji9m+z0mDPN97QdduKCuBtxPOElMGLk6YHalE4dLytc
         lqCTHeTl/Lyy1RE+vzJe2uZq/G0uQl8KNvu/EMiEbL7J6ABFeOwR+UK3MbItruKHrUfb
         LxJyHZhuvl6Ub0seVRjvp09lhVV5t2MH9G5MGsLAeK4JEnA8mVybEM4otJxTw4uLW1Q9
         H2a3LWaVNlZ6roqgavFUigrK34T4iXRf5W1OzpirmgP6bFv8ISCk+7Sz5f6mg5n3KQ4t
         cXOg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TbCvdo4F;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c9si8395616edn.152.2020.11.24.01.41.45;
        Tue, 24 Nov 2020 01:42:07 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TbCvdo4F;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731468AbgKXJh5 (ORCPT <rfc822;zhangckid@gmail.com> + 99 others);
        Tue, 24 Nov 2020 04:37:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54146 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731160AbgKXJh4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Nov 2020 04:37:56 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F056C0613D6
        for <linux-kernel@vger.kernel.org>; Tue, 24 Nov 2020 01:37:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=erVBEbSZXU0xKU0/OCceptXO8BMpPV2CdOs+DwG0M+s=; b=TbCvdo4FiP+XH83lk1czbsUuEA
        OTyCX3rCda0+ppk1biGGK9vHwCEtdw2l5r2hzwbfQhNDIHJfR0sCwpLA+DoNaxYDvK6qe6xCnfHPb
        lKBJM+WQ0UHQrhWZKyhLKrcjXbpI9XjAeY5gIN0QlLi+NG9OOZuJuwPCke5RBSUW/z6TFkSEg0FAD
        1wizpRmJ3u2zDT81oClpAEsX5u7AOH1Aq2STW23L7gdlFx3bFtYO/gq3e5Hya0qvaFalo/KeRZTP7
        UipqfF9bjU9WbEdfaDI0epSlOQx+reUs5Ob/Mnc0fP3t0jV+v5S1CDzWs1EZUqNYemD6JBN0tgf52
        hmtJmLDg==;
Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1khUlm-0008Q5-Dm; Tue, 24 Nov 2020 09:37:54 +0000
Date:   Tue, 24 Nov 2020 09:37:54 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Jani Nikula <jani.nikula@intel.com>
Cc:     linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/9] relay: make create_buf_file and remove_buf_file
 callbacks mandatory
Message-ID: <20201124093754.GC31963@infradead.org>
References: <cover.1606153547.git.jani.nikula@intel.com>
 <88003c1527386b93036e286e7917f1e33aec84ac.1606153547.git.jani.nikula@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <88003c1527386b93036e286e7917f1e33aec84ac.1606153547.git.jani.nikula@intel.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 23, 2020 at 07:59:23PM +0200, Jani Nikula wrote:
> All clients provide create_buf_file and remove_buf_file callbacks, and
> they're required for relay to make sense. There is no point in them
> being optional.
> 
> Also document whether each callback is mandatory/optional.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>