Date: Fri, 25 Aug 2006 15:56:02 -0700 (PDT)
Message-Id: <20060825.155602.132757635.davem@davemloft.net>
To: shemminger@osdl.org
Cc: sithglan@stud.uni-erlangen.de, herbert@gondor.apana.org.au,
       netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPV6 : segmentation offload not set correctly on TCP
 children
From: David Miller <davem@davemloft.net>
In-Reply-To: <20060825154353.3ecaf508@localhost.localdomain>
References: <20060821150231.31a947d4@localhost.localdomain>
	<20060821222634.GC21790@cip.informatik.uni-erlangen.de>
	<20060825154353.3ecaf508@localhost.localdomain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 20

From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 25 Aug 2006 15:43:53 -0700

> TCP over IPV6 would incorrectly inherit the GSO settings.
> This would cause kernel to send Tcp Segmentation Offload packets for
> IPV6 data to devices that can't handle it. It caused the sky2 driver
> to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050
> and the e1000 would generate bogus packets. I can't blame the
> hardware for gagging if the upper layers feed it garbage.
> 
> This was a new bug in 2.6.18 introduced with GSO support.
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Good catch.  Applied, thanks Stephen.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/