Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Nov 2020 15:26:56 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Michael Klein <michael@fossekall.de>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add
 poweroff node to DT
Message-ID: <20201124142656.wz6ipwa2xayn433x@gilmour>
References: <20201124131933.2l2go6z6ltar5fpa@gilmour>
 <20201124133633.672259-1-michael@fossekall.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vp5zfmwxtuhchxup"
Content-Disposition: inline
In-Reply-To: <20201124133633.672259-1-michael@fossekall.de>
Precedence: bulk


--vp5zfmwxtuhchxup
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 24, 2020 at 02:36:33PM +0100, Michael Klein wrote:
> Add poweroff node to allow the board to power itself off after shutdown
> by disabling the SYSTEM and CPUX regulators (U5 resp. U6).  The RST
> button can be used to restart the board.
>=20
> Signed-off-by: Michael Klein <michael@fossekall.de>
> ---
>  arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++
>  1 file changed, 5 insertions(+)

You should have a summary of the changes between versions here

> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/=
arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> index 4c6704e4c57e..ea2fa48a1647 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> @@ -46,6 +46,11 @@ sw4 {
>  		};
>  	};
> =20
> +	poweroff {
> +		compatible =3D "gpio-poweroff";
> +		gpios =3D <&r_pio 0 8 GPIO_ACTIVE_LOW>; /* PL8 */
> +	};
> +

Like I said in the previous version, this should really be modelled as a
regulator instead of just a GPIO

Maxime

--vp5zfmwxtuhchxup
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX70YMAAKCRDj7w1vZxhR
xXekAQDNMhodfkVHL9ngSP7kjTeSxw/MJwsCjsAhqiLZm0dHkQD9E90d8y8nOnaS
FERvFANkkFNagtK38l/l1bZeYVt6NQU=
=y9Dc
-----END PGP SIGNATURE-----

--vp5zfmwxtuhchxup--