Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbWHZAAl (ORCPT ); Fri, 25 Aug 2006 20:00:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932336AbWHZAAk (ORCPT ); Fri, 25 Aug 2006 20:00:40 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:12558 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S932293AbWHZAAj (ORCPT ); Fri, 25 Aug 2006 20:00:39 -0400 Date: Sat, 26 Aug 2006 09:59:41 +1000 To: Stephen Hemminger Cc: Thomas Glanzmann , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IPV6 : segmentation offload not set correctly on TCP children Message-ID: <20060825235940.GA13086@gondor.apana.org.au> References: <20060821212243.GA1558@cip.informatik.uni-erlangen.de> <20060821150231.31a947d4@localhost.localdomain> <20060821222634.GC21790@cip.informatik.uni-erlangen.de> <20060825154353.3ecaf508@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060825154353.3ecaf508@localhost.localdomain> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 25 On Fri, Aug 25, 2006 at 03:43:53PM -0700, Stephen Hemminger wrote: > TCP over IPV6 would incorrectly inherit the GSO settings. > This would cause kernel to send Tcp Segmentation Offload packets for > IPV6 data to devices that can't handle it. It caused the sky2 driver > to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050 > and the e1000 would generate bogus packets. I can't blame the > hardware for gagging if the upper layers feed it garbage. > > This was a new bug in 2.6.18 introduced with GSO support. > > Signed-off-by: Stephen Hemminger Thanks for catching this Stephen! Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/