Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1878748pxu; Tue, 24 Nov 2020 11:02:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyt0SepXHf9mVu3oyfj5iMeqlIIUwe0RmCajRGLHauHOFBbjuUflvi1b7CIylNsh2pVNvGG X-Received: by 2002:adf:f6c7:: with SMTP id y7mr6613969wrp.147.1606244544712; Tue, 24 Nov 2020 11:02:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606244544; cv=none; d=google.com; s=arc-20160816; b=0fwswg8C9deUC5S7wY9j812j+Fk9Rg83nw6M334nOChbPF7fekX7v1/B9NpLnH4KbS 8G+5ZdQbp07cDD6N2HiP834V9k4R9qAIyOjbVGCsRT9AXqOEkBbAAa3XTI/1SyZBY7uA 8NtGQ3RriU107+ij92qzGxDUli8VXsQ3qTsgKj7Ct4o/FEdR3MKX+S/FgytEbs9ltqwV PJXBKrsUQMz5423vv2wDko+abszPySTuMSjuDkhr0T5RIK0IqJGLyDrn9mwrwP2GCPwJ iTL1ouV3AotHeXxQ6GXV/6xhknHXrpSd2TiwQoWXPuagY4kGKgZlXEbdkuzDRQIkcT7Q 8jvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YQvA+gzyOlwcrQTYLcbh+JVhQ8vrnP0glY0CX55ovyw=; b=IxakAKsx5V6xUrumh2l6bQ7+Cgb2eh7uJMS+PHz5rfwsOHjR2FtdhYfyTkuz/LfDQt 0U7ItszxkVvoE557gdYJS3Jsf/dn6kBNN/8sjeXd2uSytjSoz8qm6pjsajOU+DEl8TZj 7DDOmEJVCjRJNVFsS0lu36j2eltJGgbsJXA2i7fJhFHZ/T7SOWWKfXha9JY73nfFRhdo j06f2eOq2a/u7jSbInXtUEh7/zcrldS6oytHmRymuBrA2/G+tdxc7BN9kYjKbMEq0e5u o7c5r/ZYZFwhtBwGQwCHaAxBCBd9fBpCIzCIsSLBIn08pUmQWHan9AtTO2LuBeHmGEFI cAkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hoV9a0tr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq18si8741148ejb.33.2020.11.24.11.01.59; Tue, 24 Nov 2020 11:02:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hoV9a0tr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390880AbgKXS5r (ORCPT + 99 others); Tue, 24 Nov 2020 13:57:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390718AbgKXS5q (ORCPT ); Tue, 24 Nov 2020 13:57:46 -0500 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0507DC0617A6 for ; Tue, 24 Nov 2020 10:57:45 -0800 (PST) Received: by mail-oi1-x242.google.com with SMTP id k26so24978994oiw.0 for ; Tue, 24 Nov 2020 10:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YQvA+gzyOlwcrQTYLcbh+JVhQ8vrnP0glY0CX55ovyw=; b=hoV9a0tru1XrM0PN94vfdrkGnGpCNWNEwo/32YusI1pTbAei+ybZdAf/eGFMo6toKh 3Haebkuw9HUQ0bZb6CEo++QF+NCGOT9M3mw3ndGCPpFbUdNaGsmni6ltPI0e183aAilg eUkCczMYH9u5/X6dLxzgo42js9o7y+c3SBnM4sOB6Y7fcnVWpQo78LVrzFqvXEAIF9Qp cWrFXqlv+3DDq8NPAIcs8ghau3qujNzeJK4o4iKuZjJ33uQK33/x/r9JD0Spykdn2btX r9+m/V85XrM15M8z1ZVsYb/DmekctbtqsFr6F6Ndr/6h8XCvPkyRw0iQe7kPXzXleicY pRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YQvA+gzyOlwcrQTYLcbh+JVhQ8vrnP0glY0CX55ovyw=; b=CwAwf752J+vL/TkALJWSasKKfb/MBcXdpRWSmDscP6YWsSU1bgEYeJGINKLVme5ZQH pJ0AEeAQ2SKonUN743oBUXwB2361rIHuOKIkl3UKFOrXRGisO1WSDdbr0XGU+Z1w/+GQ dkiJjr1uMt9VDba0VTZeuvaisvQsqdtSFgcTzlFTjacdmhfbYnFlZRQvoCV3mmTpf0Rd 4SGuBwKgCp4nulvdIkVFFH3O7lJ1R1wmb6B/GRZCI4omAxx30fNwIDETgneVCJPruwR2 kay5xMWMbZ0mzvlKaLEuymP+TFtCBpoJn1KKxIwXAtENi/+RzmJOzbLUjMACa5ZJKW4d q46g== X-Gm-Message-State: AOAM532b6ZaBVOQyJ8vGEvKHnniyJdvHtc6KhMAsmY4So0gdELWm+0/c 1q3IB7n5RopPPnWQ+jhlEwAORg== X-Received: by 2002:aca:4a51:: with SMTP id x78mr2449oia.86.1606244265287; Tue, 24 Nov 2020 10:57:45 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k20sm9079930ots.53.2020.11.24.10.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 10:57:44 -0800 (PST) From: Bjorn Andersson To: Andy Gross , Bjorn Andersson , Akash Asthana , Mukesh Savaliya , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Wolfram Sang , Steev Klimaszewski , Shawn Guo Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630" Date: Tue, 24 Nov 2020 12:57:43 -0600 Message-Id: <20201124185743.401946-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A combination of recent bug fixes by Doug Anderson and the proper definition of iommu streams means that this hack is no longer needed. Let's clean up the code by reverting '127068abe85b ("i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630")'. Signed-off-by: Bjorn Andersson --- drivers/i2c/busses/i2c-qcom-geni.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index dce75b85253c..046d241183c5 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -353,13 +353,11 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg, { dma_addr_t rx_dma; unsigned long time_left; - void *dma_buf = NULL; + void *dma_buf; struct geni_se *se = &gi2c->se; size_t len = msg->len; - if (!of_machine_is_compatible("lenovo,yoga-c630")) - dma_buf = i2c_get_dma_safe_msg_buf(msg, 32); - + dma_buf = i2c_get_dma_safe_msg_buf(msg, 32); if (dma_buf) geni_se_select_mode(se, GENI_SE_DMA); else @@ -394,13 +392,11 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg, { dma_addr_t tx_dma; unsigned long time_left; - void *dma_buf = NULL; + void *dma_buf; struct geni_se *se = &gi2c->se; size_t len = msg->len; - if (!of_machine_is_compatible("lenovo,yoga-c630")) - dma_buf = i2c_get_dma_safe_msg_buf(msg, 32); - + dma_buf = i2c_get_dma_safe_msg_buf(msg, 32); if (dma_buf) geni_se_select_mode(se, GENI_SE_DMA); else -- 2.29.2