Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1894200pxu; Tue, 24 Nov 2020 11:25:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5leKYhrSKYAYlhN3lUnDQQQk+doF9Fwrt2ufLGrCqH2LKb5oBhiw9mLxX7u1Jj95cTczL X-Received: by 2002:a17:906:3ec8:: with SMTP id d8mr5860102ejj.32.1606245924344; Tue, 24 Nov 2020 11:25:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606245924; cv=none; d=google.com; s=arc-20160816; b=mTHLApMOup219RKr0dBcP1kUrySUIcLT+1E0PfiILSrluCrSayDorvYogSZm26nQbw Yv6gGHi3tZ0cfskKQVbVltSTmb0ez/iG1dpJXWhnTpept9uFu44+UnJQRzlG+e8jE8XL PYtEbvfqsHPXqyoSNobw5o9tp9PBHR6MGS+SF7a+Zskc3LJ2R4mgSbAdFlLB2+M8/v2G UsvJzMOJ4zqrrIR6Sf5g6+7tI8scNib/0G8cc59/hqqmB+CYLPf3DGWiQLrxRp5Opxo3 mcOV9FxI2c5KQf2ACaQxYkLWqkaXTDouFEHLDvKU55AY2BfBStSh/EctbEredfwoT/IF sZwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=6lDZQPWdF4DEPZ+8UCsGo5SL0jghnsSc3YoqXxNKCHs=; b=IDAw8Ne9T/dD6SobxUB0EJVn6ZxBXZjR7ItZXhCOaOzh2CWrleR5d5MGB4GnhrV7Ol b7/6Ykphp91c/7UHAuhZei6k34tTt3s5geErhJQK+2RWNbKR4BfByLauk46hL4ehl4Qg fJvw6ybYPGqmt3oHfY58XyTh3LxIS+zSt2X5bhKp9ySlf/hvLVhbPN9CI2sZdcKbcwg3 aVMp8JXF2WHqpat8knb3QjAKPAWPoNNaR0nLOzdkWKvL0pif2JIiOnbM46fReIVVphuw xCHHtYwdrHpdWJoAzHek3vtBoQRFU+N9N78KGkKTbxCPa2js/A4lKvH8fETYaWcgF5CO AZTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si9196437edm.477.2020.11.24.11.25.00; Tue, 24 Nov 2020 11:25:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390986AbgKXTVQ (ORCPT + 99 others); Tue, 24 Nov 2020 14:21:16 -0500 Received: from mga02.intel.com ([134.134.136.20]:6100 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390919AbgKXTVQ (ORCPT ); Tue, 24 Nov 2020 14:21:16 -0500 IronPort-SDR: pS9IGid3UMhq7vQjDQySwdi7mA/+ewaLa+aFtTQ0QpjRbB2tRXkEu1RHAvd75seP2Q7exG86yG +XZcn+yUHbCg== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="159047623" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="159047623" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:21:14 -0800 IronPort-SDR: OLNL98UQqTjBcLDUXxkbsVgEdVfu7E4xZ239WXHSDV8ctQuGRixvVjwDyVnTWnRymaMZHSDKY/ 55TSGREREBhQ== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="478606996" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:21:14 -0800 Date: Tue, 24 Nov 2020 11:21:13 -0800 From: Ira Weiny To: Matthew Wilcox Cc: Andrew Morton , Dave Hansen , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Thomas Gleixner , Luis Chamberlain , Patrik Jakobsson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Howells , Chris Mason , Josef Bacik , David Sterba , Steve French , Jaegeuk Kim , Chao Yu , Nicolas Pitre , "Martin K. Petersen" , Brian King , Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Kirti Wankhede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core Message-ID: <20201124192113.GL1161629@iweiny-DESK2.sc.intel.com> References: <20201124060755.1405602-1-ira.weiny@intel.com> <20201124060755.1405602-2-ira.weiny@intel.com> <20201124141941.GB4327@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124141941.GB4327@casper.infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 02:19:41PM +0000, Matthew Wilcox wrote: > On Mon, Nov 23, 2020 at 10:07:39PM -0800, ira.weiny@intel.com wrote: > > +static inline void memzero_page(struct page *page, size_t offset, size_t len) > > +{ > > + memset_page(page, 0, offset, len); > > +} > > This is a less-capable zero_user_segments(). Actually it is a duplicate of zero_user()... Sorry I did not notice those... :-( Why are they called '_user_'? Ira