Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1897155pxu; Tue, 24 Nov 2020 11:30:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOLFhUuE4PMbLK6kZ0RfvMDhUJxYohwOOyk/ALCJ6yFCV6/hkLNOu2l6vuEFPSZCxG3RhX X-Received: by 2002:a05:6402:370:: with SMTP id s16mr59066edw.50.1606246223466; Tue, 24 Nov 2020 11:30:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606246223; cv=none; d=google.com; s=arc-20160816; b=OUdE3+WzmYR4nB34JKBtD7btECvgxFveZklF9DlyMoq15MozLv7XX5RY9Q3lnAgsY8 umVfXgi+1NerXBsrTrKetIv4U3kiuLCfKufi4BEwQ7e6dE2bj7G0amewf/ZGAunBukTT JEZWOxi0JvMXW8YZHDnUaC8F6sTVx2dFpbl82QH17/LHmgoAoiIMVzUl+CgGEOEzlrZi 93jqkJP95iYBudnZlfqgQad3ttBqqgrXC8teCM+8HI8gxz/wrO5iwaac9Up6cER25DBA 5tfh8wwohXWcD5CLiGo2m+FVBB1LyFjm93+kws+/xzZZ5nkxExo59vCTXofh0XMsBs0y CFjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :ironport-sdr:ironport-sdr; bh=HUBBX/nObVgPq48XBF2qadf/dm90YwucA449KOUOc8g=; b=wiEriYHQnJhTwJJ6dJZ+RMrYKYqTx/MEPnLNfrIQRggRJ/c5HnXNKmtZ5WBXhIfQ5G OBSrxtP46RtTV1MTkRTUDpFkOXA1NZNRIB1/TZCNjIsb5TnKT/6cQOOSZ1P2NQQybJU/ QYwdeAP6KCYb8DDQxIv59eM37ES4b5hzOdxMwC5hxRSqLx0d2Gf1cUIJcc/rPqKH+ufW v0u7ZO80YpGDQ7T5k7t17J3q7u9uxpztom8ZWuo/SCS2LrzWQCrzYLPk0S/M07Xt2SSI jlEsPILBwqE8dFbzd5Ecs1HMqsGzAnXjFu3apauN5/o70Hm7TilYf4PxZktp1BUoRWS8 ULWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si5263413ejh.235.2020.11.24.11.29.58; Tue, 24 Nov 2020 11:30:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404154AbgKXTZK (ORCPT + 99 others); Tue, 24 Nov 2020 14:25:10 -0500 Received: from mga18.intel.com ([134.134.136.126]:17772 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390987AbgKXTZJ (ORCPT ); Tue, 24 Nov 2020 14:25:09 -0500 IronPort-SDR: tK38+FhMbwAc+WFE+pw/hXCe1iX6ZqDIMWUzyP/RpaOOaVYp6lwGcudAr69P5PbMRfcd6hgZIc Mhas4PmUaw6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="159771502" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="159771502" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:25:08 -0800 IronPort-SDR: 6Sl8+oaY1IVjYtT30cuSTX9tyV+kga+JlcAgTnvahVIiQy/tyDZShM5V7oiCOTFgkHLbC+8Y3I MHdmSzM7LTFQ== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="478608510" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:25:08 -0800 Date: Tue, 24 Nov 2020 11:25:08 -0800 From: Ira Weiny To: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Thomas Gleixner , Dave Hansen , Matthew Wilcox , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Luis Chamberlain , Patrik Jakobsson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Howells , Steve French , Jaegeuk Kim , Chao Yu , Nicolas Pitre , "Martin K. Petersen" , Brian King , Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Kirti Wankhede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/btrfs: Convert to memzero_page() Message-ID: <20201124192508.GM1161629@iweiny-DESK2.sc.intel.com> References: <20201124060755.1405602-1-ira.weiny@intel.com> <20201124060755.1405602-6-ira.weiny@intel.com> <20201124141244.GE17322@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124141244.GE17322@twin.jikos.cz> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 03:12:44PM +0100, David Sterba wrote: > On Mon, Nov 23, 2020 at 10:07:43PM -0800, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > Remove the kmap/memset()/kunmap pattern and use the new memzero_page() > > call where possible. > > > > Cc: Chris Mason > > Cc: Josef Bacik > > Cc: David Sterba > > Signed-off-by: Ira Weiny > > --- > > fs/btrfs/inode.c | 21 +++++---------------- > > The patch converts the pattern only in inode.c, but there's more in > compression.c, extent_io.c, zlib.c,d zstd.c (kmap_atomic) and reflink.c, > send.c (kmap). Thanks... not sure how I missed reflink.c and send.c. I'll add them in v2. Thanks! Ira