Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201123161041.2304766-1-michael@fossekall.de> <4bf42c9e-9f70-bc30-1a88-44a127cd989a@sholland.org>
In-Reply-To: <4bf42c9e-9f70-bc30-1a88-44a127cd989a@sholland.org>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Tue, 24 Nov 2020 12:41:37 +0800
Message-ID: <CAGb2v65=SoATrLDKvXH-EjdVJT3E4e+yQ6Ad0Nn1BQsB9aJvog@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add
 gpio-poweroff to DT
To:     Samuel Holland <samuel@sholland.org>
Cc:     Michael Klein <michael@fossekall.de>,
        Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 24, 2020 at 12:14 PM Samuel Holland <samuel@sholland.org> wrote:
>
> On 11/23/20 10:10 AM, Michael Klein wrote:
> > Add gpio-poweroff node to allow the board to power itself off after
> > shutdown by disabling the SYSTEM and CPUX regulators (U5 resp. U6).
> > The RST button can be used to restart the board.
>
> The PSCI client will override this driver once the PSCI implementation
> is upgraded to v0.2 or newer functions. So having this around should
> cause no compatibility issues (although it would print an error in dmesg
> at that point). This seems like a reasonable thing to do for the other
> H2+/H3 boards that use a similar regulator layout.

I wonder if this (gpio-poweroff) works if those regulators are also in the DT?

> Reviewed-by: Samuel Holland <samuel@sholland.org>
>
> > Signed-off-by: Michael Klein <michael@fossekall.de>
> > ---
> >  arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > index 4c6704e4c57e..76e79e6db733 100644
> > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > @@ -46,6 +46,11 @@ sw4 {
> >               };
> >       };
> >
> > +     gpio_poweroff {
> > +             compatible = "gpio-poweroff";
> > +             gpios = <&r_pio 0 8 GPIO_ACTIVE_LOW>; /* PL8 */
> > +     };
> > +
> >       reg_vdd_cpux: vdd-cpux-regulator {
> >               compatible = "regulator-gpio";
> >               regulator-name = "vdd-cpux";
> >
>