Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1910211pxu; Tue, 24 Nov 2020 11:50:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuJYG+ZwUWFKVFiK3ez2xwj3v9uMPBdEjAn56OI7y0DbeH1ymwM7tX3QqLPfeGKT4PHDp2 X-Received: by 2002:a50:9b1c:: with SMTP id o28mr77673edi.355.1606247447430; Tue, 24 Nov 2020 11:50:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247447; cv=none; d=google.com; s=arc-20160816; b=MxBU+WgzobY5XNYouR/L+9kl/Ity2XoxOxj+3zHTQi1+/Ya/f7RMB6Nw7ewIAnlMxU OKADi8x3PRiC0vP5+6dDQd1F2wACRJGjC6LSqC2H89QwRP1lQh86SvM/wTL/bPwlIssd HD7yCwhDdLWeC6e09z6mKzKWhkyCbIYIjtUG5oBHfCyPJW7Qe6VmJ5ilS6HNrWyL4mC6 VuOlN8oJ78rR2sG0B3vj9nOuuhiOlNjre8rgt0o6MY0vkKvcQ2bENjGMK+kOxIM4buQo lr2/AWRWat/D74sJC5qEsZk7SRm15CiVp+lmo4vWhdxqtWfQ2U6LN+42wk3jqjJ4Btl0 g35g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=QTIyqwnvrQgZ96roCLtdHbNGK1Tk+dzUd8gPA1K/abY=; b=yqtBiShU/v5LQvjJYR88FW/YHh/p+e7eGXp7Qi8ilpWvWNfyLC3N3fPoGzwLRLPyL9 8bIgvFolq0Nd1RHgXxgZXJCFlZBRF+VHnzhagwdrR3y79fkoVA6K1qN6j1nGezd/7G1x 3aTEwaOryOozh6oc/rdlWMH45B3A7U7SLT8lBsp5autIzSRX4SGngiq8L3/QzsDSZaV7 PChduUo7keP+DPjyKZenuKt6TEn4UucNyJpf7FmsmDB63Je3JL4vBbh/J7H3bqmrpuuX ngg7v2WMui4Zxh331xknClbQReyQLFYq1Kj/tuRcw3+czsKOneEnLewwfWhlturqwJVv 4WoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si9937018ejr.648.2020.11.24.11.50.24; Tue, 24 Nov 2020 11:50:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729479AbgKXHBD (ORCPT + 99 others); Tue, 24 Nov 2020 02:01:03 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7972 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbgKXHBD (ORCPT ); Tue, 24 Nov 2020 02:01:03 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CgFKT5rJMzhf2r; Tue, 24 Nov 2020 15:00:45 +0800 (CST) Received: from euler.huawei.com (10.175.124.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Tue, 24 Nov 2020 15:00:52 +0800 From: Wei Li To: Dominik Brodowski , Andrew Morton , "Peter Zijlstra (Intel)" , Olof Johansson CC: , Subject: [PATCH] drivers/pcmcia: Fix error return code in electra_cf_probe() Date: Tue, 24 Nov 2020 15:00:40 +0800 Message-ID: <20201124070040.3583-1-liwei391@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When it fails to call of_get_property(), it just jumps to 'fail1', while the 'status' which will be returned is not updated. Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards") Signed-off-by: Wei Li --- drivers/pcmcia/electra_cf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index 35158cfd9c1a..0570758e3fa8 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -228,6 +228,7 @@ static int electra_cf_probe(struct platform_device *ofdev) } cf->socket.pci_irq = cf->irq; + status = -ENODEV; prop = of_get_property(np, "card-detect-gpio", NULL); if (!prop) -- 2.17.1