Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
CC:     "broonie@kernel.org" <broonie@kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: RE: [EXT] [PATCH] spi: imx: enable runtime pm support
Thread-Topic: [EXT] [PATCH] spi: imx: enable runtime pm support
Thread-Index: AQHWY9/iuScipEkFI0KzKaHjGfcnQqnGdAMAgBFCRvA=
Date:   Tue, 24 Nov 2020 08:57:28 +0000
Message-ID: <AM6PR04MB562348A699215824A00E29ECF3FB0@AM6PR04MB5623.eurprd04.prod.outlook.com>
References: <20200727063354.17031-1-xiaoning.wang@nxp.com>
 <20201113091800.27469-1-nikita.shubin@maquefel.me>
In-Reply-To: <20201113091800.27469-1-nikita.shubin@maquefel.me>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f1aaa479-edc9-4ff3-2415-08d89056f89f
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 08:57:28.4652
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: n9uAPahWLyn0Ah6DgxX8i+OGAz6scIoGenw0TwBWjOZ5urMhPdU9/pcEZE0rllMi7TgpEakTcpM16rmSeaWufA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7077
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Nikita,

Sorry for this issue caused by my patch.
Yes, it because I did not add the !CONFIG_PM support when add the runtime p=
m patch. This may cause the clks cannot be enabled when do not enable CONFI=
G_PM.
Sascha has fix this issue with the patch:
43b6bf406cd0 spi: imx: fix runtime pm support for !CONFIG_PM

You may try the latest upstream driver again.

I also fix a warning dump issue with CONFIG_PM enabled. It is under reviewe=
d. So that, this driver can work well in both cases.

Thanks!

Best Regards,
Clark Wang

> -----Original Message-----
> From: Nikita Shubin <nikita.shubin@maquefel.me>
> Sent: Friday, November 13, 2020 17:18
> To: Clark Wang <xiaoning.wang@nxp.com>
> Cc: broonie@kernel.org; festevam@gmail.com; kernel@pengutronix.de;
> linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-kernel@vger.kernel.org; linux-spi@vger.kernel.org;
> s.hauer@pengutronix.de; shawnguo@kernel.org; Nikita Shubin
> <nikita.shubin@maquefel.me>
> Subject: [EXT] [PATCH] spi: imx: enable runtime pm support
>=20
> Caution: EXT Email
>=20
> Hello Clark,
>=20
> This patch breaks spi-imx on imx7d.
> Toradex Colibri imx7d spi reports with:
>=20
>     [    4.258468] inv-mpu6000-spi spi2.0: I/O Error in PIO
>     [    4.264269] inv-mpu6000-spi spi2.0: SPI transfer failed: -110
>     [    4.264305] spi_master spi2: failed to transfer one message from q=
ueue
>=20
> We are using spi-imx with dma.
>=20
> Reverting your patch fixes this issue.
>=20
> The baseline commit 951cbbc386ff01b50da4f46387e994e81d9ab431 (tag:
> v5.9.8, stable/linux-5.9.y)
>=20
> Could you please give some comments on this issue ?