Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2002080pxu; Tue, 24 Nov 2020 14:26:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKjkjBi+hj3GV1lNEMXX+lgu8E85ktdN3RDYRWIyLaex+phdvDCJzBjdbMx5pnnq27kgWJ X-Received: by 2002:a17:906:b791:: with SMTP id dt17mr583974ejb.438.1606256801256; Tue, 24 Nov 2020 14:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606256801; cv=none; d=google.com; s=arc-20160816; b=uhVWID+cfMbv9EC/Yc9K+5dWbsFtoAxlc2fDYM+FdwAYBKRC695PzSok1Hc9mhcp7Q /xnz3SYR5sHUrxV6lpoUV+is2EuZFSB1uJUoC4eWyk5oUBAc/WTLb9ysx21Elyac0VAj PJ0TBfz1Mpq5aZVtCkd6Nh8ELP9SlZfxdFwzsbhlh4yrVf7675GXfZOFNiPTRQVgiYs5 8lQAgmlyit5+0KKtaQuR4PkUPYlaWsQZtXrtW6UhgTcH4gLgf/ieAAS8gIyWuZnzd1EG 1GRTkx8t0ohVnyiCYhaJSbbIXDlKjezV4BDBaec0x87a3+YjGCyu8nGgqXhkuZ76sGGQ SLig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wznd4qYRDhL+Pld6MvcykH/GmbtOIMB6XyOR0bz4z48=; b=VVlMM3W5DzJ8cAln+mIHPjTcyI2bgAUbmZYyc7UJuAuEXtrTnxEAuFIjk4uuE/AM65 5GZMP29yTHKmnGMpkJ3SMZ473h1jqmwumiMVYb6pBke6F6n6qcebUqZJZlJiTb9nonvv CFgF60HWIvsXU9THkeTpbVMSjMKWjibU+q7kof1oFgihC39DBsEA3DQ499U5owhCY5Sl IcuG1ENqgVXQAtrYAe4g2+FlCbPAzf92jucBMgEyMMlnafHJcfA0F62MPg+C+VyRst3K P0daZuuncM1cW8i+o7KSEABOiuhbscm1RHW4hNj9SudypOkf6Wzk244v6mIu9yhZf8wQ 0EdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uLXfpeHp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si149057ejy.598.2020.11.24.14.26.18; Tue, 24 Nov 2020 14:26:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uLXfpeHp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388692AbgKXOPC (ORCPT + 99 others); Tue, 24 Nov 2020 09:15:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:50046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388659AbgKXOPA (ORCPT ); Tue, 24 Nov 2020 09:15:00 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8690120866; Tue, 24 Nov 2020 14:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606227299; bh=wPxwPSYUJQvenwuxZ8Stbfu0z1HC9dk+8Z9jU6IDIhQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uLXfpeHpaZ9aPQRFVdueYCQZ8dNyAd3w6YeeFmVIdMbvh1NO1kn5CzctmCH/56bOs MWsdtLWLPKO4LFd1TpuAoVO4HPMp2/69yCGpDdTNTeeZNdItO6uTMfvXgYJR2khCWo ps7UyOyqxB6xOBm8Wu6k5n/TUTRqouP58f85mbVY= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1khZ5s-00DGcy-PH; Tue, 24 Nov 2020 14:14:57 +0000 From: Marc Zyngier To: LAK , linux-kernel Cc: Will Deacon , Catalin Marinas , Thomas Gleixner , Valentin Schneider , Peter Zijlstra , Mark Rutland , Russell King , Android Kernel Team Subject: [PATCH v2 5/6] genirq: Drop IRQ_HIDDEN from IRQF_MODIFY_MASK Date: Tue, 24 Nov 2020 14:14:48 +0000 Message-Id: <20201124141449.572446-6-maz@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201124141449.572446-1-maz@kernel.org> References: <20201124141449.572446-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, Valentin.Schneider@arm.com, peterz@infradead.org, mark.rutland@arm.com, linux@arm.linux.org.uk, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IRQ_HIDDEN is hardly a flag generic code should use, so let's drop it from IRQF_MODIFY_MASK. In turn, update both arm and arm64 to use __irq_modify_status() when setting this flag. Signed-off-by: Marc Zyngier --- arch/arm/kernel/smp.c | 2 +- arch/arm64/kernel/smp.c | 2 +- include/linux/irq.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 0e09c8320caf..dc746f808400 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -737,7 +737,7 @@ void __init set_smp_ipi_range(int ipi_base, int n) WARN_ON(err); ipi_desc[i] = irq_to_desc(ipi_base + i); - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN); + __irq_modify_status(ipi_base + i, 0, IRQ_HIDDEN, ~0); /* The recheduling IPI is special... */ if (i == IPI_RESCHEDULE) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index bad51f7f7ffe..684f41a3ba58 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -994,7 +994,7 @@ void __init set_smp_ipi_range(int ipi_base, int n) WARN_ON(err); ipi_desc[i] = irq_to_desc(ipi_base + i); - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN); + __irq_modify_status(ipi_base + i, 0, IRQ_HIDDEN, ~0); /* The recheduling IPI is special... */ if (i == IPI_RESCHEDULE) diff --git a/include/linux/irq.h b/include/linux/irq.h index 605ba5949255..0e71227fd3ec 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -107,7 +107,7 @@ enum { (IRQ_TYPE_SENSE_MASK | IRQ_NOPROBE | IRQ_NOREQUEST | \ IRQ_NOAUTOEN | IRQ_MOVE_PCNTXT | IRQ_LEVEL | IRQ_NO_BALANCING | \ IRQ_PER_CPU | IRQ_NESTED_THREAD | IRQ_NOTHREAD | IRQ_PER_CPU_DEVID | \ - IRQ_IS_POLLED | IRQ_DISABLE_UNLAZY | IRQ_HIDDEN) + IRQ_IS_POLLED | IRQ_DISABLE_UNLAZY) #define IRQ_NO_BALANCING_MASK (IRQ_PER_CPU | IRQ_NO_BALANCING) -- 2.28.0