Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2042715pxu; Tue, 24 Nov 2020 15:38:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0/L3GHf8nrbERHAEVV2MU5FaJbC9WMHEe6//ccsrBFdi7LRq8Xy83TmjD6w6JmE9aZ/PD X-Received: by 2002:a17:907:4335:: with SMTP id ni5mr752003ejb.459.1606261117970; Tue, 24 Nov 2020 15:38:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606261117; cv=none; d=google.com; s=arc-20160816; b=U5hdkxyhXPDH7iHk14zex3G73c+2/MEPHi0EZNkMl6XxfJjcg+IILsNy3EV3lz8g6t PHTB1D8TjxOo3RdPQy+e7xXo3G/nByO6TZEf43r02G58F7qFZWoqmY1EQb6FBZXaYHQQ pm8x/jKn1uy9b2kylvGeA40WqxEFumCPb4rtgejvgBRV6e/Ufs4vUInMQYUI3RM/ZWEU n9SHa9iz+Ha7knTfcPQy8u8NpUIJnr92X+XlTOKQjkJ72a5FDx5irxc7voNTh69VAQGn HBtTRnKSB5W4jfcrZVraz8imP12bbxPaUbCNbB0VyIzUsI1MmotWd/4Tt8005GqW24U2 /J2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=beptYMt7+eafD2ZEQSEovk9FzgjHfPs3g/lAfS8j9uM=; b=o/93V4LSvf/gx+6/2yxFWvsYkpcPCv+q+hVlEtRG15yMKtfrCmA0OtZEG6UpmHGjnH S8DuNVO2Q4DXHau0J/6J1CI+8/3maYeorQt8fdhwgjFi6AWCtrfTECWA7GwmuPwnKPIS jT2IRU4jqKNjCY3k135B6u1OaSd1EaRNAzdcYeRlCcxPn7z2EzNW7gWMfLFQq48UdjtR PmKTmdnM5/siRBq8yYPxAnl4vDX3zaImLSXNunNWoPz0z/BQBySrIF9iCIQA1qs1bxbA LuMrQctp6dHDT2MjAIifuBKMclvgywplfV/S9kb6ln4IUFHl0lhFiEWst8VXxByiG1W/ Rruw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si127118edh.227.2020.11.24.15.38.14; Tue, 24 Nov 2020 15:38:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390392AbgKXQW5 (ORCPT + 99 others); Tue, 24 Nov 2020 11:22:57 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42001 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390160AbgKXQW4 (ORCPT ); Tue, 24 Nov 2020 11:22:56 -0500 Received: by mail-wr1-f65.google.com with SMTP id l1so22894871wrb.9; Tue, 24 Nov 2020 08:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=beptYMt7+eafD2ZEQSEovk9FzgjHfPs3g/lAfS8j9uM=; b=t/FNO/fvyKb5Pp9X5qeI/wK96CCsRhoEuWSjU5FNQGJeDNh/RIqckAR8R/30U8d/9i yY9l2zZhHfFVoqoms9HhW9BuxDgUeIBpvBVKsZ6nSrhiPoFpfeRearN7xTY9d8dIOjnU oGRXBBGh78QxEwAxziJFBHEiMTW4sbeOkwp9Pg6ADyu/bmifX1pWOCBAgaXGHWYP+kH5 DAStr7Bac8O09h6tTVsL7C2Iyof8tjnrPp/fEqO4fW1L4fXdxsOyByzjeiuFR6PEHyKa GnFsnmeKpDwX4svHNbT76UIieBOvKOBNVr9uQMP9UH+nA4vWBrlV2gutUYX0sSq8JGgW cp8Q== X-Gm-Message-State: AOAM533qVYbmYaxRPFvrGkzPxjg60SYW2T6G7pPLtwMc3nzuLTubemDO FgHYm5BgyOzaCwBBqG6ilDk= X-Received: by 2002:adf:f441:: with SMTP id f1mr6141880wrp.225.1606234975722; Tue, 24 Nov 2020 08:22:55 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id x9sm20773316wrt.70.2020.11.24.08.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 08:22:55 -0800 (PST) Date: Tue, 24 Nov 2020 16:22:53 +0000 From: Wei Liu To: Jakub Kicinski Cc: "Andrea Parri (Microsoft)" , linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org, Michael Kelley , Juan Vazquez , Saruhan Karademir , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] hv_netvsc: Validate number of allocated sub-channels Message-ID: <20201124162253.3qpfgo7rtvut4nqn@liuwe-devbox-debian-v2> References: <20201118153310.112404-1-parri.andrea@gmail.com> <20201118173715.60b5a8f2@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118173715.60b5a8f2@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2020 at 05:37:15PM -0800, Jakub Kicinski wrote: > On Wed, 18 Nov 2020 16:33:10 +0100 Andrea Parri (Microsoft) wrote: > > Lack of validation could lead to out-of-bound reads and information > > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > > allocated sub-channels fits into the expected range. > > > > Suggested-by: Saruhan Karademir > > Signed-off-by: Andrea Parri (Microsoft) > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: netdev@vger.kernel.org > > Acked-by: Jakub Kicinski Applied to hyperv-next.