Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Nov 2020 14:11:19 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: warn if gso_type isn't set for a GSO SKB
Message-ID: <20201124141119.49972889@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <97c78d21-7f0b-d843-df17-3589f224d2cf@gmail.com>
References: <97c78d21-7f0b-d843-df17-3589f224d2cf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 21 Nov 2020 00:22:20 +0100 Heiner Kallweit wrote:
> In bug report [0] a warning in r8169 driver was reported that was
> caused by an invalid GSO SKB (gso_type was 0). See [1] for a discussion
> about this issue. Still the origin of the invalid GSO SKB isn't clear.
> 
> It shouldn't be a network drivers task to check for invalid GSO SKB's.
> Also, even if issue [0] can be fixed, we can't be sure that a
> similar issue doesn't pop up again at another place.
> Therefore let gso_features_check() check for such invalid GSO SKB's.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=209423
> [1] https://www.spinics.net/lists/netdev/msg690794.html
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, thanks!