Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp35709pxu; Tue, 24 Nov 2020 17:45:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGwEzws2SDMuG3nQF1Bm6YElNdnlnZrbNXc3qltRS9JCo/jrvpfJm5bQd/7NX/b0EymsGk X-Received: by 2002:aa7:d493:: with SMTP id b19mr1284020edr.279.1606268708742; Tue, 24 Nov 2020 17:45:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606268708; cv=none; d=google.com; s=arc-20160816; b=prqqUgjeVGTC4wx7+4C/cKL1axePBOxsErfy1BFV7VhFkQNwc1C+PwOUZXTizDvHyc l+B8ZFA6Zn0qTQ4pHOvUE3hHFdsm364I+2q5Vamw6m9LhGRMFga8BKXRejNzNoabYCN1 PTucVivXBk8D9vYT5g96WTp/yWrKtw+sRA/BK9sxnGGnNSPeWrC3qXL7jn4w1nObfaIQ qnnqFq4Mki9DQQ9nw2SJjsMUyCutXhrpKoyvUABycKm1+IE2X/yF21/s1knF9FLE36Wc dfWNNTaDdeRY2ZK/4SozNDlqD/RatoojwAwML7ARlU5kX5fFu8unePOR3m2/zzOI654M kKEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UT1q0ssjr3ASFBM7Q8x9Xmg4gFYhYnL1VbvfVxfMkx4=; b=f+geVo8IGUl0sJ6cqpA4uIR9gQpoWzk1ZV8MfBN6SeXSnEV3AO2oB+ONmG5n789rBG L1+CfB0HyVJAiqj9+QprHzZoRVWOZGVCt5iNOSCb6BAIDOpvMEXNDmA+6Sb28Oqb1AuN sHORwP1P95hFLsHd3eRcZu7feYhvCmzdGmGLNbcs00Dg+eBVQ+/Ql69hEdYIRaJTqr+W g//vT6sfBfbq28lKbhGnrD8d710Cqtrc0n4sWsbAYXZuMbR9RD08WrrviUk9dGehOfGt cZkJnzfI4UARQuZK6Oxt/F4VLmUO04PfC3LZivAj036AQCpMqKXRM39ZCQ51TLQDeSME u9xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=C5WaOft0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a42si408287edf.129.2020.11.24.17.44.45; Tue, 24 Nov 2020 17:45:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=C5WaOft0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbgKXD6T (ORCPT + 99 others); Mon, 23 Nov 2020 22:58:19 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:36268 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbgKXD6S (ORCPT ); Mon, 23 Nov 2020 22:58:18 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AO3tiwW078846; Tue, 24 Nov 2020 03:58:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=UT1q0ssjr3ASFBM7Q8x9Xmg4gFYhYnL1VbvfVxfMkx4=; b=C5WaOft0oQUomsIrVXh6cBW8UqeAkux1AaCNbOfrCfKsXbv5prH1yt/I8mtqPeTwJ3zc kdiTG6KVlEHBLxkf5lLQxKybKezFFCYyig6n2E9Lav/S08emEMiEJwpcVh6bD68f0QJs iKpHavyiFeSKsTLq9JlaKjNfzLbABwTMZZRqdWPyoilY66ELQM8brBNSmNEWkBuygTxd V+9ZOwordu/TXKys21X6rjHJUJ1eQPjK9jMYnPsNIYu994UEaRr7pZhrGR4vU9Wjx84v jLzK0ybt+wL8E5ogQBauWirzMmDRhcqUGaPCzoJ5z4Fh75v8+tFB1G/WhYNAwLa0TaJz lg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 34xtaqkyks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Nov 2020 03:58:13 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AO3toB2080899; Tue, 24 Nov 2020 03:58:12 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 34ycnrvyy2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Nov 2020 03:58:12 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AO3wBZ5009620; Tue, 24 Nov 2020 03:58:11 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 23 Nov 2020 19:58:11 -0800 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, James Smart , Colin King , "James E . J . Bottomley" , Dick Kennedy Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue Date: Mon, 23 Nov 2020 22:58:00 -0500 Message-Id: <160618683552.24173.13742714512709142456.b4-ty@oracle.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201118131345.460631-1-colin.king@canonical.com> References: <20201118131345.460631-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9814 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240021 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9814 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240021 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020 13:13:45 +0000, Colin King wrote: > There is a null check on pointer lpfc_cmd after the pointer has been > dereferenced when pointers rdata and ndlp are initialized at the start > of the function. Fix this by only assigning rdata and ndlp after the > pointer lpfc_cmd has been null checked. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Fix pointer defereference before it is null checked issue https://git.kernel.org/mkp/scsi/c/1e7dddb2e76a -- Martin K. Petersen Oracle Linux Engineering