Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 24 Nov 2020 11:39:51 +0000
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     "Ye, Xiang" <xiang.ye@intel.com>
CC:     Jonathan Cameron <jic23@kernel.org>, <jikos@kernel.org>,
        <srinivas.pandruvada@linux.intel.com>,
        <linux-input@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver
Message-ID: <20201124113951.000009ea@Huawei.com>
In-Reply-To: <20201124064332.GA21403@host>
References: <20201119100331.2594-1-xiang.ye@intel.com>
        <20201119100331.2594-5-xiang.ye@intel.com>
        <20201121175629.057031af@archlinux>
        <20201124064332.GA21403@host>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk


> >   
> > > +
> > > +	  To compile this driver as a module, choose M here: the
> > > +	  module will be called hid-sensor-custom-hinge.
> > > +
> > >  endmenu
> > > diff --git a/drivers/iio/position/Makefile b/drivers/iio/position/Makefile
> > > index 3cbe7a734352..7a6225977a01 100644
> > > --- a/drivers/iio/position/Makefile
> > > +++ b/drivers/iio/position/Makefile
> > > @@ -5,3 +5,6 @@
> > >  # When adding new entries keep the list in alphabetical order
> > >  
> > >  obj-$(CONFIG_IQS624_POS)	+= iqs624-pos.o
> > > +
> > > +obj-$(CONFIG_HID_SENSOR_CUSTOM_HINGE) += hid-sensor-custom-hinge.o  
> > 
> > Alphabetical order preferred.
> >   
> > > +ccflags-y	+= -I$(srctree)/drivers/iio/common/hid-sensors  
> > 
> > Why?  
> hinge driver need to include #include "hid-sensor-trigger.h", if not using this cflag-y
> it should be #include "../common/hid-sensors/hid-sensor-trigger.h"

Even though that looks a bit ugly, I'd prefer that rather than having to realize we
were doing something not entirely obvious in the Makefile.

Thanks,

Jonathan