Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "pawell@cadence.com" <pawell@cadence.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch
 class"
Thread-Topic: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch
 class"
Thread-Index: AQHWwY7qvaWheOMvwU2q0XXgyvVqyqnW1uYAgAAxWYCAAAPXgIAAC1EAgAAUboA=
Date:   Tue, 24 Nov 2020 11:47:10 +0000
Message-ID: <20201124114641.GA9929@b29397-desktop>
References: <20201123115051.30047-1-rogerq@ti.com>
 <20201124064242.GA32310@b29397-desktop>
 <89067b6a-5b94-d7d2-b07a-f434c9e5e2bd@ti.com>
 <DBBPR04MB797982E6E190F0C0E0980F258BFB0@DBBPR04MB7979.eurprd04.prod.outlook.com>
 <bdb2b4cb-686e-9283-bc66-78808b92c349@ti.com>
In-Reply-To: <bdb2b4cb-686e-9283-bc66-78808b92c349@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A97FDE914E60C64FACA826C0FA1CE657@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4a897b-2303-4730-ba7d-08d8906ead87
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 11:47:10.4374
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ly4yRfeB7HfUhHEj2OlmrKW9cp9YlI6o7urtc6TPfAuQCkzNZLu99DerajpPM1EvBv6TZ9/E6nohrAzdQn62mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6716
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-11-24 12:33:34, Roger Quadros wrote:
> > > >=20
> > > > I am sorry about that. Do you use role switch /sys entry, if you ha=
ve
> > > > used, I prefer using "usb-role-switch" property at dts to judge if =
SoC
> > > > OTG signals or external signals for role switch. If you have not us=
ed
> > > > it, I prefer only setting cdns->role_sw for role switch use cases.
> > > >=20
> > >=20
> > > We use both hardware role switch and /sys entries for manually forcin=
g a
> > > certain role.
> > >=20
> > > We do not set any "usb-role-switch" property at DTS.
> > >=20
> > > Currently cdns->role_sw is being always set by driver irrespective of=
 any DT
> > > property, so this patch is clearly wrong and needs to be reverted.
> > >=20
> > > What do you think?
> > >=20
> >=20
> > Could you accept below fix?
> >=20
> > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> > index 2e469139769f..fdd52e87a7b2 100644
> > --- a/drivers/usb/cdns3/core.c
> > +++ b/drivers/usb/cdns3/core.c
> > @@ -280,8 +280,8 @@ int cdns3_hw_role_switch(struct cdns3 *cdns)
> >          enum usb_role real_role, current_role;
> >          int ret =3D 0;
> >=20
> > -       /* Depends on role switch class */
> > -       if (cdns->role_sw)
> > +       /* quit if switch role through external signals */
> > +       if (device_property_read_bool(cdns->dev, "usb-role-switch"))
> >                  return 0;
> >=20
> >          pm_runtime_get_sync(cdns->dev);
>=20
> Although this will fix the issue I don't think this is making the driver =
to behave
> as expected with usb-role-switch property.
>=20
> Now, even if usb-role-switch property is not present the driver will stil=
l register
> the role switch driver.
>=20
> I think we need to register the role switch driver only if usb-role-switc=
h property
> is present. We would also need to set the default role if role-switch-def=
ault-mode is present.
>=20
> How about the following? It still doesn't handle role-switch-default-mode=
 property though.
>=20

Roger, you said you also use /sys entries (I suppose it means through role
switch class) to do role switch, with your change, there will be no /sys
entry for role switch.

Peter

> > > We use both hardware role switch and /sys entries for manually forcin=
g a
> > > certain role.


> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 4c1445cf2ad0..986b56a9940c 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -532,11 +532,13 @@ static int cdns3_probe(struct platform_device *pdev=
)
>  	if (device_property_read_bool(dev, "usb-role-switch"))
>  		sw_desc.fwnode =3D dev->fwnode;
> -	cdns->role_sw =3D usb_role_switch_register(dev, &sw_desc);
> -	if (IS_ERR(cdns->role_sw)) {
> -		ret =3D PTR_ERR(cdns->role_sw);
> -		dev_warn(dev, "Unable to register Role Switch\n");
> -		goto err3;
> +	if (device_property_read_bool(cdns->dev, "usb-role-switch")) {
> +		cdns->role_sw =3D usb_role_switch_register(dev, &sw_desc);
> +		if (IS_ERR(cdns->role_sw)) {
> +			ret =3D PTR_ERR(cdns->role_sw);
> +			dev_warn(dev, "Unable to register Role Switch\n");
> +			goto err3;
> +		}
>  	}
>  	if (cdns->wakeup_irq) {
>=20
>=20
>=20
> cheers,
> -roger
> --=20
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

--=20

Thanks,
Peter Chen=