Date: Sat, 26 Aug 2006 22:31:27 +0300
From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Robert Walsh <rjwalsh@pathscale.com>
Cc: Roland Dreier <rdreier@cisco.com>, linux-kernel@vger.kernel.org,
       openib-general@openib.org
Subject: Re: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
Message-ID: <20060826193126.GF21168@mellanox.co.il>
Reply-To: "Michael S. Tsirkin" <mst@mellanox.co.il>
References: <44EF6053.4010006@pathscale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44EF6053.4010006@pathscale.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1484
Lines: 40

Quoting r. Robert Walsh <rjwalsh@pathscale.com>:
> Subject: Re: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Roland Dreier wrote:
> > 1) What makes ipath special so that we want this warning for ipath
> > devices but not other IB hardware?
> 
> There's nothing special about our hardware that requires this.  We just
> wanted that in there so we could direct customers to look at dmesg to
> see if the warning popped up if they call with a problem.  It is useful
> to have for this purpose.
> 
> > If this warning is actually
> > useful, then I think it would make more sense to start a timer when
> > any IB device is added, and warn if ports with a physical link don't
> > become active after the timeout time.
> 
> I'd be OK with doing that, too.

Looks like your devices are all single-port. With a multi port
device it is quite common to have one port down.

> > But I'm having a hard time
> > seeing why we want this message in the kernel log.
> 
> It's useful when you're trying to track down problems.

How about doing this in userspace by looking at port state in sysfs?
You can diagnose a much wider class of problems this way.

-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/