Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp48047pxu; Tue, 24 Nov 2020 18:12:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnzT6bUJT/dsQIceFNiWzIQfEN3OsSNFjv3wSViRcC5eOKziJdMGtr2Il5QLVLpd/XukpE X-Received: by 2002:a05:6402:1d85:: with SMTP id dk5mr1352521edb.283.1606270376307; Tue, 24 Nov 2020 18:12:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606270376; cv=none; d=google.com; s=arc-20160816; b=FO52NkBFAX9dtSCJE414J3LzpJMV5wYTy+cf7btYzHOTXY+bCaRscLJ0kH+Rofbege C4PyzYGEFl491hRtlTXPDdkHQWvstEjUfVX+8PJOWQY64GtS3UeAmTjLigGi3M6wk2Cb 8x4HNlPIapePsGzlv882uq/RxX+A2ytod+yQ7dz9kT8op6Csdl3t8fiJzxcYkQPkGlhi J3EUwwQaRgrM30eSHINx4Je7qpOfAPaJdbuuFtLdtmsdCM+0mE3D506gICbw+nAUI3u9 c4L60xrJ1d0f9b9KsSpCa02O9V/Jr/eo0KvpFONyNb9VsXg4nqat9MZHG4MYqkt4B+6V 3e4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=8UhenPuo9tV1L527/igukALKNl3OoBIsOn2IxX/5JQI=; b=qgSANXdT0bbugdWCCSLgYeHQ0vYCwait0j3ELVv09IXtbfDj3EIMyz1yvR5/bE9Lci pGt/QRFmQAVXatxOFWW2xtH1hDRyqckCfLbM7TXTdlVomCF9RD2ibtuZnPeJxSnkEyV2 rdMLnFK2PEYflPxAuP5OKVBHIFabt+0tOuW7a/afy00KhvHHN+S4S1ifkqNwkpaN8gFT 6H1mVB347SzA0kt9lGU+OQRS9163IxjZNbUos34+mV2NW0t9uUlQZ3StHPHYSytkjJBz SIxsmBzQrBJhb4sdd3E4i/QLvVsd4Ofrm+Xm/ugPRPKyOoaI1VejAWVpQcnEPxgrTjsT bX6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJHypOeL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f5si24404edw.349.2020.11.24.18.12.33; Tue, 24 Nov 2020 18:12:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJHypOeL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbgKYCGY (ORCPT + 99 others); Tue, 24 Nov 2020 21:06:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:37040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgKYCGX (ORCPT ); Tue, 24 Nov 2020 21:06:23 -0500 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66CAE2067D; Wed, 25 Nov 2020 02:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606269983; bh=iwIWhrMn6QmFc+tknI5JAn3HLJvGt8AXMGD/Vwy263s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=RJHypOeL30X1wAE/0WLrkf+vjEo4OHYMMmK6+txIyHr0mdGBJkHCj7pmntl8Bu5Ge 7yq/1C5SKUK6YrhCgi1y+E33+HQ9oecyS2RjhcO91tku5y5pkYtggk0i3GawP1FpKs HoeVqfni/Z7L/w6vZ9MUgWxfIgzYM5nvGLEv+O9o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201120161839.GD3870099@ulmo> References: <20201029004820.9062-1-nicoleotsuka@gmail.com> <20201120161656.GC3870099@ulmo> <20201120161839.GD3870099@ulmo> Subject: Re: [PATCH] clk: tegra: Do not return 0 on failure From: Stephen Boyd Cc: Nicolin Chen , jonathanh@nvidia.com, pgaikwad@nvidia.com, pdeschrijver@nvidia.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org To: Michael Turquette , Thierry Reding Date: Tue, 24 Nov 2020 18:06:22 -0800 Message-ID: <160626998208.2717324.3699032150208058364@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Thierry Reding (2020-11-20 08:18:39) > On Fri, Nov 20, 2020 at 05:16:56PM +0100, Thierry Reding wrote: > > On Wed, Oct 28, 2020 at 05:48:20PM -0700, Nicolin Chen wrote: > > > Return values from read_dt_param() will be either TRUE (1) or > > > FALSE (0), while dfll_fetch_pwm_params() returns 0 on success > > > or an ERR code on failure. > > >=20 > > > So this patch fixes the bug of returning 0 on failure. > > >=20 > > > Fixes: 36541f0499fe ("clk: tegra: dfll: support PWM regulator control= ") > > > Cc: > > > Signed-off-by: Nicolin Chen > > > --- > > > drivers/clk/tegra/clk-dfll.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > Mike, Stephen, > >=20 > > if you don't mind, I'll pick this up in the Tegra tree since there are a > > few other Tegra clock patches on the list that may require coordination > > inside the Tegra tree. >=20 > Also, I do plan on sending the collected set of patches to you for > inclusion via PR at a later date, if that's okay with you. >=20 Ok sure.