Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp55264pxu; Tue, 24 Nov 2020 18:31:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxUfLA5Drn4JLPpQrAuB2jMA36gqrNIs80qxRv0CYSStHscVubEdnGIpaL02WiY8JJMmicz X-Received: by 2002:aa7:d3d6:: with SMTP id o22mr1426607edr.243.1606271462828; Tue, 24 Nov 2020 18:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606271462; cv=none; d=google.com; s=arc-20160816; b=q7nk+O84ySSRaTg2L8cle2fJ21j3QYhO6czAwpawQG0MUOrMLortrrSQJQQWBneAEv rleQt3IKoQbgxku4+qK2LDI3TZftEDlktPcpP17veHOr9BGpYA8SX4ylRtiam3f6NeVS m1oA14v2foJirosASxvbX3aXZd2VZvL6TTpG8uY7UqRmwwQr86yzZ0Q28n4Yd389vLjS OAEtHM65QhTLTXn+mAhqAHDJBokokmsCrejRcqyiYCue4qJDo6t+h91YOnY18/3YVGe5 pvV3LFCI0bZEo/H6T/NeLY8dd/XkI3EBkLc9qKUiCIn5d5grrmwHLSRtQ7VaHxgn6CPp IKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=RGlPTwgZ9WQNVVo/OnIGq8qnUHzMPoJhjz9hSt+91uU=; b=nxHiujGP6CJHbdffq+DatjEG3JhDNhxZsEEe5UCv+svNZTPvttJgrEPRnM7+7e9X3U D7H0uYW5dJwmv28NixB3utWvsgFRjOY1Dpic6XrjOoLIxBVAi6pRtNH8O5YDY/3i3NlU qen0or0rwNw4f0dsy3WQUSH0MZf+9Zxyix124Z9kiaAaMdAyUHuOHKkDN4ndAkv2YzCS 7DUEoVUYVVcRlcnBMzQmFZrIhAREQhRm4BgQXOBoeW3DajWutcR+AnCkRorbny11nJFs P7kVMN2DimpW7Iq8mQccaiFsjy2fq3KDG7QUvhFJ47uzCm0uh3BLyMdeCm0AUwA07wFv CqxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si365536edv.187.2020.11.24.18.30.38; Tue, 24 Nov 2020 18:31:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726929AbgKYC2f (ORCPT + 99 others); Tue, 24 Nov 2020 21:28:35 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7676 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbgKYC2f (ORCPT ); Tue, 24 Nov 2020 21:28:35 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CglCx01mgz15Qf1; Wed, 25 Nov 2020 10:27:41 +0800 (CST) Received: from [10.57.101.250] (10.57.101.250) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Nov 2020 10:27:56 +0800 Subject: Re: [PATCH v2 04/18] arm: dts: hisi-x5hd2: Harmonize EHCI/OHCI DT nodes name To: Serge Semin , Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Rob Herring , Greg Kroah-Hartman References: <20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru> <20201111091552.15593-5-Sergey.Semin@baikalelectronics.ru> CC: Serge Semin , , , From: Wei Xu Message-ID: <5FBDC12B.9060200@hisilicon.com> Date: Wed, 25 Nov 2020 10:27:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20201111091552.15593-5-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Serge, On 2020/11/11 17:15, Serge Semin wrote: > In accordance with the Generic EHCI/OHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible > nodes are correctly named. > > Signed-off-by: Serge Semin > Acked-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > index 3ee7967c202d..693b85b2cc7d 100644 > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > @@ -452,14 +452,14 @@ gmac1: ethernet@1841000 { > status = "disabled"; > }; > > - usb0: ehci@1890000 { > + usb0: usb@1890000 { > compatible = "generic-ehci"; > reg = <0x1890000 0x1000>; > interrupts = <0 66 4>; > clocks = <&clock HIX5HD2_USB_CLK>; > }; > > - usb1: ohci@1880000 { > + usb1: usb@1880000 { > compatible = "generic-ohci"; > reg = <0x1880000 0x1000>; > interrupts = <0 67 4>; > Thanks! But a similar patch has been sent out earlier: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201012061225.1597-4-thunder.leizhen@huawei.com/ Best Regards, Wei