Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: oMkXBEV6BPd3otyzMVqMqckpjZ8w6sAeMHgaSmEDogNewx81VVht3kc/faZ5q0/lJROAcQTOds
 f7y0hbP28zlg==
IronPort-SDR: wy5G5y0Lgp/bDGnStObfoSCHHMJMAz51c+bkMx8e0iguqsyW5Rlj5WrxTdg5t/dIZvs3moOsbq
 VNYziQGci8gw==
Date:   Wed, 25 Nov 2020 10:39:00 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     jikos@kernel.org, jic23@kernel.org,
        srinivas.pandruvada@linux.intel.com, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver
Message-ID: <20201125023900.GA10254@host>
References: <20201119100331.2594-1-xiang.ye@intel.com>
 <20201119100331.2594-5-xiang.ye@intel.com>
 <20201121175629.057031af@archlinux>
 <20201124064332.GA21403@host>
 <20201124113951.000009ea@Huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201124113951.000009ea@Huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi,

On Tue, Nov 24, 2020 at 11:39:51AM +0000, Jonathan Cameron wrote:
> 
> > >   
> > > > +
> > > > +	  To compile this driver as a module, choose M here: the
> > > > +	  module will be called hid-sensor-custom-hinge.
> > > > +
> > > >  endmenu
> > > > diff --git a/drivers/iio/position/Makefile b/drivers/iio/position/Makefile
> > > > index 3cbe7a734352..7a6225977a01 100644
> > > > --- a/drivers/iio/position/Makefile
> > > > +++ b/drivers/iio/position/Makefile
> > > > @@ -5,3 +5,6 @@
> > > >  # When adding new entries keep the list in alphabetical order
> > > >  
> > > >  obj-$(CONFIG_IQS624_POS)	+= iqs624-pos.o
> > > > +
> > > > +obj-$(CONFIG_HID_SENSOR_CUSTOM_HINGE) += hid-sensor-custom-hinge.o  
> > > 
> > > Alphabetical order preferred.
> > >   
> > > > +ccflags-y	+= -I$(srctree)/drivers/iio/common/hid-sensors  
> > > 
> > > Why?  
> > hinge driver need to include #include "hid-sensor-trigger.h", if not using this cflag-y
> > it should be #include "../common/hid-sensors/hid-sensor-trigger.h"
> 
> Even though that looks a bit ugly, I'd prefer that rather than having to realize we
> were doing something not entirely obvious in the Makefile.
Okay, will remove ccflags-y in the makefile

Thanks
Ye, Xiang
> 
> Thanks,
> 
> Jonathan