Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: hongwus=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 25 Nov 2020 10:51:35 +0800
From:   hongwus@codeaurora.org
To:     "Asutosh Das (asd)" <asutoshd@codeaurora.org>
Cc:     Can Guo <cang@codeaurora.org>, nguyenb@codeaurora.org,
        ziqichen@codeaurora.org, rnayak@codeaurora.org,
        linux-scsi@vger.kernel.org, kernel-team@android.com,
        saravanak@google.com, salyzyn@google.com,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        open list <linux-kernel@vger.kernel.org>,
        asutoshd=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8
 error happens
In-Reply-To: <1b2aacf0-ebc2-e541-2db5-2d595b4b392f@codeaurora.org>
References: <1605596660-2987-1-git-send-email-cang@codeaurora.org>
 <1605596660-2987-4-git-send-email-cang@codeaurora.org>
 <1b2aacf0-ebc2-e541-2db5-2d595b4b392f@codeaurora.org>
Message-ID: <ff38a5b8e55fe6b5a740c2d30c9c3f37@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2020-11-18 01:23, Asutosh Das (asd) wrote:
> On 11/16/2020 11:04 PM, Can Guo wrote:
>> When AH8 error happens, all the regs and states are dumped in err 
>> handler.
>> Sometime we need to look into host regs right after AH8 error happens,
>> which is before leaving the IRQ handler.
>> 
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> ---
> 
> Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> 
>>   drivers/scsi/ufs/ufshcd.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index cd7394e..a7857f6 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -6057,7 +6057,8 @@ static irqreturn_t ufshcd_check_errors(struct 
>> ufs_hba *hba)
>>   		hba->saved_uic_err |= hba->uic_error;
>>     		/* dump controller state before resetting */
>> -		if ((hba->saved_err & (INT_FATAL_ERRORS)) ||
>> +		if ((hba->saved_err &
>> +		     (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK)) ||
>>   		    (hba->saved_uic_err &&
>>   		     (hba->saved_uic_err != UFSHCD_UIC_PA_GENERIC_ERROR))) {
>>   			dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",
>> 

Reviewed-by: Hongwu Su<hongwus@codeaurora.org>