Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <60b60d026a0636090b1617c6fd9e7b3a88013a7f.camel@perches.com>
Subject: Re: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING
From:   Joe Perches <joe@perches.com>
To:     Matheus Castello <matheus@castello.eng.br>,
        Michael Kelley <mikelley@microsoft.com>
Cc:     "sashal@kernel.org" <sashal@kernel.org>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Sunil Muthuswamy <sunilmut@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Stephen Hemminger <sthemmin@microsoft.com>
Date:   Tue, 24 Nov 2020 18:56:14 -0800
In-Reply-To: <ada0ef93-1443-49a0-914c-1ad03ffa024b@castello.eng.br>
References: <20201115195734.8338-1-matheus@castello.eng.br>
         <20201115195734.8338-5-matheus@castello.eng.br>
         <MW2PR2101MB1052B329DFC5D54F4D7501E9D7E40@MW2PR2101MB1052.namprd21.prod.outlook.com>
         <ada0ef93-1443-49a0-914c-1ad03ffa024b@castello.eng.br>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote:
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
> > The above would be marginally better if organized as follows so that the
> > main execution path isn't in an "if" clause.  Also reduces indentation.
> > 
> > 	hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
> > 	if (!hv_panic_page) {
> > 		pr_err("Hyper-V: panic message page memory allocation failed");

And nicer to add a terminating newline to the format like the pr_err below.

> > 		return;
> > 	}
> > 	ret = kmsg_dump_register(&hv_kmsg_dumper);
> > 	if (ret) {
> > 		pr_err("Hyper-V: kmsg dump register error 0x%x\n", ret);
> > 		hv_free_hyperv_page((unsigned long)hv_panic_page);
> > 		hv_panic_page = NULL;
> > 	}