Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp68871pxu; Tue, 24 Nov 2020 19:04:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8gdjsuGg0oJwYGdotUaYD8YyEFCYWWYJpu8SpEUbv7nvIx9c1nOj1f6uXbkia6QM+qOdT X-Received: by 2002:a05:6402:2206:: with SMTP id cq6mr1489920edb.163.1606273483137; Tue, 24 Nov 2020 19:04:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606273483; cv=none; d=google.com; s=arc-20160816; b=yHVnVutyzqDwSvqRKeicLb1RF01TgqMoWUN8TpD03526NSvVNfr1yGuIO/9zKIDljU 8UlWOpsPC4bebnWIwzdHilWQez3X+hv+2QJUKK8mimMuVIbcRMc5PHs4OT0BLEDG49jc HH1i7uKMTRM5ixPVms9rDTEebe95s2SsyioQo4fXUsFV8ynvMUfNA65ynwuPHW9TipxG XUxxj6YvLcqyP526VIq1JgT1/MPfDzX6unALZJbB+hYusaad9bNwOlNPOdb0Sy8yyH5E pNWSraKvNas3PiSlLjAQuVZH4l3ixAJAZpWt6dCZIAphETYI8i1AWWre6oNQLbBZUFJu qSng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vBv4Fb39HVdGJ1zVwFFd8JvgoMglbZ6jD8fSoBf07qc=; b=JeuuiMao4sRLeiEUG94LRlhEYBbqrb9dQRwtmsdTpT+KLqvX5CJRCvc3QvTN8mLPFT UAZW6Edp7BjvBoBG/JVh4JfDFHghZqwETxXQY8bETq+G+YruF7fdGjbPUalcjTPzEggP znozINmO8qJ7OyM59X7ye92VBH5Qpy/+7AppSnuLiHvYwTfPiwZ66gKmow6/GnlyF2fY W0okp7hpMxInYryDDHp+i8x/iCVGPU8g5aMI+TfggJa1V/duKNzyicekv3aLBY468HzX 1616/YkAnbTQrzeVfEOJIcEEHaqj2w0BYceITbNptn0QS15rd/UWD1/1Iogpd7JOEEri f2fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=NVQkkbzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df6si417183edb.508.2020.11.24.19.04.20; Tue, 24 Nov 2020 19:04:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=NVQkkbzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727990AbgKYDBp (ORCPT + 99 others); Tue, 24 Nov 2020 22:01:45 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:49290 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbgKYDBo (ORCPT ); Tue, 24 Nov 2020 22:01:44 -0500 Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AP2rZuR008328 for ; Tue, 24 Nov 2020 19:01:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=vBv4Fb39HVdGJ1zVwFFd8JvgoMglbZ6jD8fSoBf07qc=; b=NVQkkbzqucw9j107v5YAIGilNV9cVJuX1YztRjI3YvNEO/7DTDV7CZa8Fq+eSkIPq8ZP WATmLO4W0TDy07lhcZshLv1m9xilomPVBBUJYNG7z1BZSx00ynde7hLRB7nbdwadGNE0 VgSF7YblzIitR+ruebjy0LUaNsl9ZuuNZgI= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 351dspg700-18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 24 Nov 2020 19:01:44 -0800 Received: from intmgw001.06.prn3.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 24 Nov 2020 19:01:32 -0800 Received: by devvm3388.prn0.facebook.com (Postfix, from userid 111017) id 33EE916A18A1; Tue, 24 Nov 2020 19:01:22 -0800 (PST) From: Roman Gushchin To: CC: , , , , , , , Subject: [PATCH bpf-next v8 16/34] bpf: refine memcg-based memory accounting for sockmap and sockhash maps Date: Tue, 24 Nov 2020 19:01:01 -0800 Message-ID: <20201125030119.2864302-17-guro@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20201125030119.2864302-1-guro@fb.com> References: <20201125030119.2864302-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-24_11:2020-11-24,2020-11-24 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=13 spamscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011250018 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include internal metadata into the memcg-based memory accounting. Also include the memory allocated on updating an element. Signed-off-by: Roman Gushchin --- net/core/sock_map.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/core/sock_map.c b/net/core/sock_map.c index ddc899e83313..3ff635af737a 100644 --- a/net/core/sock_map.c +++ b/net/core/sock_map.c @@ -39,7 +39,7 @@ static struct bpf_map *sock_map_alloc(union bpf_attr *a= ttr) attr->map_flags & ~SOCK_CREATE_FLAG_MASK) return ERR_PTR(-EINVAL); =20 - stab =3D kzalloc(sizeof(*stab), GFP_USER); + stab =3D kzalloc(sizeof(*stab), GFP_USER | __GFP_ACCOUNT); if (!stab) return ERR_PTR(-ENOMEM); =20 @@ -975,8 +975,9 @@ static struct bpf_shtab_elem *sock_hash_alloc_elem(st= ruct bpf_shtab *htab, } } =20 - new =3D kmalloc_node(htab->elem_size, GFP_ATOMIC | __GFP_NOWARN, - htab->map.numa_node); + new =3D bpf_map_kmalloc_node(&htab->map, htab->elem_size, + GFP_ATOMIC | __GFP_NOWARN | __GFP_ACCOUNT, + htab->map.numa_node); if (!new) { atomic_dec(&htab->count); return ERR_PTR(-ENOMEM); @@ -1116,7 +1117,7 @@ static struct bpf_map *sock_hash_alloc(union bpf_at= tr *attr) if (attr->key_size > MAX_BPF_STACK) return ERR_PTR(-E2BIG); =20 - htab =3D kzalloc(sizeof(*htab), GFP_USER); + htab =3D kzalloc(sizeof(*htab), GFP_USER | __GFP_ACCOUNT); if (!htab) return ERR_PTR(-ENOMEM); =20 --=20 2.26.2