Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Laurentiu Tudor <laurentiu.tudor@nxp.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Diana Madalina Craciun <diana.craciun@nxp.com>,
        Cristian Sovaiala <cristian.sovaiala@freescale.com>
Subject: Re: [PATCH] bus: fsl-mc: added missing fields to
 dprc_rsp_get_obj_region structure
Thread-Topic: [PATCH] bus: fsl-mc: added missing fields to
 dprc_rsp_get_obj_region structure
Thread-Index: AQHWwlKrhkkTQ0CtQEmepYUhDibtPanYbDKA
Date:   Wed, 25 Nov 2020 06:58:48 +0000
Message-ID: <20201125065847.xrirmlmctpx2yrns@skbuf>
References: <20201124111200.1391-1-laurentiu.tudor@nxp.com>
In-Reply-To: <20201124111200.1391-1-laurentiu.tudor@nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8D233EE265FD1B43A79A318AF40FDD7C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fe9a481-6c7c-4d93-a9f0-08d8910f8f25
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2020 06:58:48.4122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sPvBCHN0690vHNMgi/wPMtXSY56UQC48AQjvBm9MA/kLMm2IccF3HzrtpW696O5eYmj8bR/EoRpJhW3XABpvyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5887
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 24, 2020 at 01:12:00PM +0200, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>=20
> 'type' and 'flags' fields were missing from dprc_rsp_get_obj_region
> structure therefore the MC Bus driver was not receiving proper flags
> from MC like DPRC_REGION_CACHEABLE.
>=20
> Signed-off-by: Cristian Sovaiala <cristian.sovaiala@freescale.com>
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

> ---
>  drivers/bus/fsl-mc/dprc.c           | 2 ++
>  drivers/bus/fsl-mc/fsl-mc-private.h | 5 +++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
> index 57b097caf255..27b0a01bad9b 100644
> --- a/drivers/bus/fsl-mc/dprc.c
> +++ b/drivers/bus/fsl-mc/dprc.c
> @@ -576,6 +576,8 @@ int dprc_get_obj_region(struct fsl_mc_io *mc_io,
>  	rsp_params =3D (struct dprc_rsp_get_obj_region *)cmd.params;
>  	region_desc->base_offset =3D le64_to_cpu(rsp_params->base_offset);
>  	region_desc->size =3D le32_to_cpu(rsp_params->size);
> +	region_desc->type =3D rsp_params->type;
> +	region_desc->flags =3D le32_to_cpu(rsp_params->flags);
>  	if (dprc_major_ver > 6 || (dprc_major_ver =3D=3D 6 && dprc_minor_ver >=
=3D 3))
>  		region_desc->base_address =3D le64_to_cpu(rsp_params->base_addr);
>  	else
> diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl=
-mc-private.h
> index 85ca5fdee581..c932387641fa 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-private.h
> +++ b/drivers/bus/fsl-mc/fsl-mc-private.h
> @@ -211,12 +211,13 @@ struct dprc_cmd_get_obj_region {
> =20
>  struct dprc_rsp_get_obj_region {
>  	/* response word 0 */
> -	__le64 pad;
> +	__le64 pad0;
>  	/* response word 1 */
>  	__le64 base_offset;
>  	/* response word 2 */
>  	__le32 size;
> -	__le32 pad2;
> +	u8 type;
> +	u8 pad2[3];
>  	/* response word 3 */
>  	__le32 flags;
>  	__le32 pad3;
> --=20
> 2.17.1
> =