Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 08:06:27 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Thorsten Scherer <thorsten.scherer@eckelmann.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2 2/2] siox: Make remove callback return void
Message-ID: <20201125070627.ragkxfs56czkcrfv@pengutronix.de>
References: <20201124141834.3096325-1-u.kleine-koenig@pengutronix.de>
 <20201124141834.3096325-3-u.kleine-koenig@pengutronix.de>
 <20201124205845.jma7lay5tux6wiav@ws067.eckelmann.group>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cixxissz6k4lxedf"
Content-Disposition: inline
In-Reply-To: <20201124205845.jma7lay5tux6wiav@ws067.eckelmann.group>
Precedence: bulk


--cixxissz6k4lxedf
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 24, 2020 at 09:58:45PM +0100, Thorsten Scherer wrote:
> Hello,
>=20
> On Tue, Nov 24, 2020 at 03:18:34PM +0100, Uwe Kleine-K=F6nig wrote:
> > The driver core ignores the return value of the remove callback, so
> > don't give siox drivers the chance to provide a value.
> >
> > All siox drivers only allocate devm-managed resources in
> > .probe, so there is no .remove callback to fix.
> >
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/siox/siox-core.c | 5 ++---
> >  include/linux/siox.h     | 2 +-
> >  2 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> > index b56cdcb52967..1794ff0106bc 100644
> > --- a/drivers/siox/siox-core.c
> > +++ b/drivers/siox/siox-core.c
> > @@ -525,12 +525,11 @@ static int siox_remove(struct device *dev)
>=20
> Shouldn't this return void?

This is the callback used for struct device_driver::remove (and after
patch 2 struct bus_type::remove) which still has to return int. But in
the long run I want to change these to void, too.

Best regards and thanks for your feedback
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--cixxissz6k4lxedf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl++Am0ACgkQwfwUeK3K
7AmNCAgAgcexh6x35DGDrKcMUYhkwLcKDlnYu2H7CWi8lQeDHo1C0PoFBIEcoR5Y
fU6zpkrQlysxf3A6Kgbes0PwD5T9xIGw4Umjmm1mnFRjdaAQW5HKP1gebxZ5wp/5
POcRPDO2NHO1h7XbBKTJsvB4sO0HC/es3gEx8q49INgBKhBkAKuqQ1kVkv8BywbK
vDK1AFbA241KBgP83iGj+zBuOrvOV9GKthAiE52APtPpw67mcHvbYmU5eUof6Y69
MpO1abp8T89CQdrNZ0Pssxs204Qw354qxJKdCPKB19AcGHCoZtAvhhmGL5rOzqnR
Anp1nBkWebGFBZlLwlTVATaPYy0nKg==
=PKyt
-----END PGP SIGNATURE-----

--cixxissz6k4lxedf--