Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp197389pxu; Wed, 25 Nov 2020 00:11:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXMagtdLKX0US3naZT5+fxIzKcXUILZbfImadkuNHkSv6HanzR8zyDSJGQenhxof+s4E6z X-Received: by 2002:a17:906:4705:: with SMTP id y5mr2152872ejq.112.1606291897836; Wed, 25 Nov 2020 00:11:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606291897; cv=none; d=google.com; s=arc-20160816; b=TVUq5x6y9wrnBSncWVfse2A1akKdNPrCRGPnVgHMvmxZ0G048CcawrN5uOu4i3V5pf gZG01wt7M8ZPUqfGjkUzfEDOLYYCztfyu9A8SSbKaFPpOGE9Xt7LZ/uEj4+5+DrEj8js OCcbckKtLh08Wio9ax2/xcWh1kSCvZcbGHf10d8Agddyj+8q47ePAUYFKNv7tZS3jO9M Uas6Uk+dOALMPHkRYoDDpMB9Dj4ZTSOBTRGh1IT9j+MQZvX84+g3BJbQ1CPVFiLbbLGx r/jrd9pALCQefWenB+Uc3I8/cPwVFFB827bX56E+YdFaQeHO+RbqEbih/uLexCg6wxli rMwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=hEtaTJIru09c6ocTH2Gdh94iNszK2om5mGDRLgYs5bA=; b=n+71JZf3Q8nbXx3QuYTBdvDcpKa/H2ehVXn1wijMK7eCv/wGc9nFN0B/ej1DIWNDje KKeRibDyuvJRSrcyK/Q2z2EaTxtj/+P+hlqEUpCJoNUrJUM5mKrw5FzPw+4PzinLoJmO M67aag46fftllnJAGnvg3nAH7IbJaKN3BbGITNIA/LvxI8yxhBCvw09X9q1y906DFZ87 ddLI8VzZIDee1A1eOpgiiCGt1A4ukqRZ3T/pW1groMF39qcI9ByB7MQGtU0jAYV75xda hepAvD8UPRvcnS87c10sgzTwnwCPonNhRsjb8TssIrf8qtpNdf6iacpvbH1+BHIC5q5o 1xHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u92si776169edc.306.2020.11.25.00.11.13; Wed, 25 Nov 2020 00:11:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbgKYIIs (ORCPT + 99 others); Wed, 25 Nov 2020 03:08:48 -0500 Received: from mga07.intel.com ([134.134.136.100]:55243 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbgKYIIr (ORCPT ); Wed, 25 Nov 2020 03:08:47 -0500 IronPort-SDR: UDQY2SUrIK9J24AtSW1A+1oBANrW4p6Hb1cnM7e1FjZ8KAQFbjBGufUlpPc+uh/QNYBnU3yAHl DuanINuZQWGg== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="236223224" X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="236223224" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 00:08:46 -0800 IronPort-SDR: d89wyNIp/4sQKU38ifwFZ5XXb+cpLwQcHD9SOaPhNOn3QIZ8cYwwijxxMXdIOweNsRxHSYri+e 13UJofcaabdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="362239500" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.94]) ([10.237.72.94]) by fmsmga004.fm.intel.com with ESMTP; 25 Nov 2020 00:08:45 -0800 Subject: Re: [PATCH] mmc: sdhci: Use more concise device_property_read_u64 To: Jeremy Linton , linux-mmc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, ulf.hansson@linaro.org References: <20201125033630.603863-1-jeremy.linton@arm.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <2f28f4c7-6f00-33ee-ac38-211c6fb07702@intel.com> Date: Wed, 25 Nov 2020 10:08:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201125033630.603863-1-jeremy.linton@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/20 5:36 am, Jeremy Linton wrote: > Since we only need a single u64 the _array form is > unnecessarily. Use device_property_read_u64 instead. > > Signed-off-by: Jeremy Linton Thank you :-) Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index feba64fbde16..ad4ae88a7f74 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver, > if (host->v4_mode) > sdhci_do_enable_v4_mode(host); > > - device_property_read_u64_array(mmc_dev(host->mmc), > - "sdhci-caps-mask", &dt_caps_mask, 1); > - device_property_read_u64_array(mmc_dev(host->mmc), > - "sdhci-caps", &dt_caps, 1); > + device_property_read_u64(mmc_dev(host->mmc), > + "sdhci-caps-mask", &dt_caps_mask); > + device_property_read_u64(mmc_dev(host->mmc), > + "sdhci-caps", &dt_caps); > > v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION); > host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT; >