Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp198736pxu; Wed, 25 Nov 2020 00:14:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFUdJYZ7bzc6CYo159ybFob3NIYLiCD6VBeuIEvAfAq7id5fdiHGjldAJLJPL8mqO8V2IO X-Received: by 2002:aa7:ca41:: with SMTP id j1mr2398844edt.295.1606292062292; Wed, 25 Nov 2020 00:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606292062; cv=none; d=google.com; s=arc-20160816; b=uuG5CyD4vIqw2DM+S1ZmvNwe7p13O04MLtg3XEjAR7ufkAHjNR3twTwlrMqKjBnyNu 5xPXdNHUwddfhK4HPwgDYHUUr+ti2TviCN+oghDSWPScIv9TRUVH0UNTea2TtKSSj+Df CbJ8iBcas9X53Oe4w5kMcfVLKgyTD8up6cP9V1xF6vpAVPQhEMCwd57uExqlTmzpAxe2 Kpp2N0wBuzftA2EHNC+l6sHT23heC+StAsb2ZTnFuEe3GZ3u0V5sKWJKiFJtmFMtK/K/ AtIj6MXiaanCnSIQIp2v5fcer4zPfCTs03lMMGdgKn45ZgQS0UBYXJNOGPAMrYo3HQXl elJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=8WBrqKdegLc2aS0Qybc1e+FLb+foBiEuZSdNQeKkGbc=; b=sRgRvF5vPauo3sRv5lGv6YiNNYFbuFI8VKwvXVEiYxA/5jbj2IaXqE0Id82b13uHpf IL45Ee2U5lYY2bB2LWhgE9KrBgSKrgZbnUiDP9tuReBSztlnknOfzKxTnizftziW5Wob xSkKIh1EXmnwGNiZHLOBwf3GtWLtc0zwiCsrp/FqtGVZpNIgc+ejcYQstHxe8tuk7eY/ O9rfxylHEckqbmKoKMpJp1hC8UNWQXb5S1juSxv9ssBhFVwg+XPRu08ck4VEV/oF6qqe vDgfNEw/C6PPLxgOa8udywvRT+Q0lwnuavemhtWvDXENmMHl+UuWpCBlnNdGIKwF7SlF h5hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n17si777859ejh.609.2020.11.25.00.13.59; Wed, 25 Nov 2020 00:14:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728194AbgKYIJT (ORCPT + 99 others); Wed, 25 Nov 2020 03:09:19 -0500 Received: from mga14.intel.com ([192.55.52.115]:60172 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbgKYIJT (ORCPT ); Wed, 25 Nov 2020 03:09:19 -0500 IronPort-SDR: SlnXGnSGkSdPCCEpHYOiEpvuLYvA0gXzSxps7l0KtTmV+7xriM3irRWbRDVh7HU5odNeUyGLbD 8AEbZtt3BrPg== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="171308887" X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="171308887" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 00:09:18 -0800 IronPort-SDR: 86ykC7dgvOHKt2RYbLrc+JeVaxAzHUL73SvgE0Ig+dHLXnxBUW3yvpM2Bxo5qmUV1elo+vb50H B8z52QfRh9hA== X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="362239650" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 00:09:12 -0800 Received: by lahna (sSMTP sendmail emulation); Wed, 25 Nov 2020 10:09:10 +0200 Date: Wed, 25 Nov 2020 10:09:10 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linux ACPI , LKML , Linux PM , Linux PCI , "Rafael J. Wysocki" , Bjorn Helgaas , Kai-Heng Feng Subject: Re: [PATCH v1 2/2] PM: ACPI: Refresh wakeup device power configuration every time Message-ID: <20201125080910.GC2532@lahna.fi.intel.com> References: <27714988.CF3CpBaniU@kreacher> <1717218.WU8ttdIIEu@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1717218.WU8ttdIIEu@kreacher> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 08:46:38PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > When wakeup signaling is enabled for a bridge for the second (or every > next) time in a row, its existing device wakeup power configuration > may not match the new conditions. For example, some devices below > it may have been put into low-power states and that changes the > device wakeup power conditions or similar. This causes functional > problems to appear on some systems (for example, because of it the > Thunderbolt port on Dell Precision 5550 cannot detect devices plugged > in after it has been suspended). > > For this reason, modify __acpi_device_wakeup_enable() to refresh the > device wakeup power configuration of the target device on every > invocation, not just when it is called for that device first time > in a row. > > Signed-off-by: Rafael J. Wysocki > Reported-by: Kai-Heng Feng > Tested-by: Kai-Heng Feng Reviewed-by: Mika Westerberg