Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ZNtvEjo9tOomJlVVHZKysFCOiIPgV/spZt653PN9BTWNG/BTQhNduJ/x1dkg0SmVQt8Svf0xMR
 oUeC3QLj7xRw==
IronPort-SDR: GheNTKL25l/fUDdau6XuMD22VQz/1wGPF2TtB6rDS7D+EZP51yZam17yFnpX27YCUZZaoXEKlk
 /BjCnfxy08aQ==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>, Tom Rix <trix@redhat.com>,
        "Moritz Fischer" <mdf@kernel.org>
CC:     "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] fpga: dfl: add missing platform_device_put in
 build_info_create_dev
Thread-Topic: [PATCH] fpga: dfl: add missing platform_device_put in
 build_info_create_dev
Thread-Index: AQHWwvbIXBL/p8/Zj0+C9gs0iUUR8KnYnV3Q
Date:   Wed, 25 Nov 2020 10:06:10 +0000
Message-ID: <DM6PR11MB381903C990E8D7C76EF04E5F85FA0@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20201125065030.154074-1-miaoqinglang@huawei.com>
In-Reply-To: <20201125065030.154074-1-miaoqinglang@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c51cd6b3-2e19-49f3-7eef-08d89129bc27
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2020 10:06:10.8147
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qt5brIdmlpoJ8hQGjX0y9vnnsCSEaPezfBoQsMVa+Zgwd6XeMdd37boG8/0V3sk0kE2/hxJKixbgZl+kXSrQTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2073
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] fpga: dfl: add missing platform_device_put in
> build_info_create_dev
>=20
> platform_device_put is missing when it fails to set fdev->id. Set
> a temp value to do sanity check.

will this case be covered already by build_info_free()?

Hao

>=20
> Fixes: 543be3d8c999 ("fpga: add device feature list support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  drivers/fpga/dfl.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index b450870b7..8958f0860 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -877,10 +877,13 @@ build_info_create_dev(struct
> build_feature_devs_info *binfo,
>=20
>  	INIT_LIST_HEAD(&binfo->sub_features);
>=20
> -	fdev->id =3D dfl_id_alloc(type, &fdev->dev);
> -	if (fdev->id < 0)
> -		return fdev->id;
> +	int tmp_id =3D dfl_id_alloc(type, &fdev->dev);
> +	if (tmp_id < 0) {
> +		platform_device_put(fdev);
> +		return tmp_id;
> +	}
>=20
> +	fdev->id =3D tmp_id;
>  	fdev->dev.parent =3D &binfo->cdev->region->dev;
>  	fdev->dev.devt =3D dfl_get_devt(dfl_devs[type].devt_type, fdev->id);
>=20
> --
> 2.23.0