Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp311315pxu; Wed, 25 Nov 2020 04:00:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzon47ov6qyyFE0qp53rdP1RWIsKCOf0e6wVkNRMjrOVhCwFA/f5/z3VkHTWlhVD+hIcMcb X-Received: by 2002:a17:907:250c:: with SMTP id y12mr2876044ejl.367.1606305606078; Wed, 25 Nov 2020 04:00:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606305606; cv=none; d=google.com; s=arc-20160816; b=grAw+PA5hgR7tlytmik/JrkvKd+OKl9hdPqewQfm4X0emfbZxtcUW+XskdAM7Bcc5h Eya2pVfDNSJxsvTbAIjNKhO7jc+jIZiWTxdaqlY848j2nxIpz2fujNQlPsqtmtMyPq5+ rOp/w48MUOwW/8F3wTf3i3XZLeWNAlYlKzdv0uAZo7qseLbp4MMzy/EdQGCPmVgA7OkA hyFUI8D2BbJWqq/IIdgCK6EOOMbQ+aouucs4xwkCh3zx9pwDMPPXU+PgcrOpx/NU87UJ +vRIN8vnOSdJg+wBJHJnaj2iaG37ptdwTfPNzCW9c+Gj1R0tcJseOaAgbn9mC4TmHE98 X0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:references:in-reply-to :cc:to:from; bh=dIAjbgOieJPzhhW+s1FXCYwASW1utb/9onORp0j+868=; b=Zq9DttAz7IRsse49BMUCrIV4kHU2Nmx5uTK6xtOn9rtu9GUzj+UHIA94qWN2eg3BKv GkDMP8jmkMQEQyIVTaLrqnq12Rp1zGw4sBG/TAwqbNt6EbjhFsXWQASK3s3Jus3oelrL +m8Kx98NHhQAYCoZK1nDrJFae7Ek51L42vmMe7jjGVFtQHNMDxAlPVwCK+CT+70Fa/MK ZA3x5ELzWJ+nDHHspmhfLcJOLUkF0DvVf0rZUkWCmt0o5BIQPnqTYt7qOXM8AWryWVmL xGP3g25FJXFfO/k3kE2hMZlmjU4ToepXO0CQ8oFZewKGDSZWGQhoYjLlphfoDW1kMxYS wINA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec19si1125375ejb.669.2020.11.25.03.59.43; Wed, 25 Nov 2020 04:00:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729047AbgKYL55 (ORCPT + 99 others); Wed, 25 Nov 2020 06:57:57 -0500 Received: from ozlabs.org ([203.11.71.1]:44437 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgKYL55 (ORCPT ); Wed, 25 Nov 2020 06:57:57 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 4Cgzsp6Xgnz9sVf; Wed, 25 Nov 2020 22:57:50 +1100 (AEDT) From: Michael Ellerman To: Qinglang Miao , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <20201028091551.136400-1-miaoqinglang@huawei.com> References: <20201028091551.136400-1-miaoqinglang@huawei.com> Subject: Re: [PATCH] powerpc: sysdev: add missing iounmap() on error in mpic_msgr_probe() Message-Id: <160630540026.2174375.17196584614414099920.b4-ty@ellerman.id.au> Date: Wed, 25 Nov 2020 22:57:50 +1100 (AEDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2020 17:15:51 +0800, Qinglang Miao wrote: > I noticed that iounmap() of msgr_block_addr before return from > mpic_msgr_probe() in the error handling case is missing. So use > devm_ioremap() instead of just ioremap() when remapping the message > register block, so the mapping will be automatically released on > probe failure. Applied to powerpc/next. [1/1] powerpc: sysdev: add missing iounmap() on error in mpic_msgr_probe() https://git.kernel.org/powerpc/c/ffa1797040c5da391859a9556be7b735acbe1242 cheers