Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp311803pxu; Wed, 25 Nov 2020 04:00:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCVFmMxKzSz6RQU+U1Yzj1e+gtlro7Vo3Di0ceMe0jjhBxgBSCrKqbH6kGFaEGBP0mgGLL X-Received: by 2002:a17:906:28d4:: with SMTP id p20mr2845427ejd.322.1606305636194; Wed, 25 Nov 2020 04:00:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606305636; cv=none; d=google.com; s=arc-20160816; b=flq81kvehF9ZxdDWg1gGufcKhIdOU7uqO9YzQ8XVF4SbE7JFBbl0yEm3K1ywWEY7TA Zq78KZ+nWO2GrrlkeTJIEwqCLsmGIgiYSr4vBEBl/bA/JyBgDLaCNzzrpSRVvxu0aHdj dUEDWXP3CDYL4WlMK3x0LzZilh5oenNcxXPQvhyG+DrJi+yr5+uVe+HNy8UEEtjMSRvf lgmtuJhfiEyTk5aL0i/UxYaWZpjO3K+mVQ4eVVAMR5YHuc+NoPVoR+wtqBp25sI2mio7 J+JQyXkm1RR2e+xHlkyRmrzur8+C95HYdiZzG/9Q8gdQrBcBSMZKa1+K4TIrG4LDnAUZ vGQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:references:in-reply-to :cc:to:from; bh=ntz8KF8/22KMhrjneyBnau3+JpBGZNjn9nePF5UITpk=; b=xbPk68NsRDCCrPf4UYZKHbHp++nenFQARpmK/HcGz6FOqVNg5sJQT0lSo6yb78jIjQ +HnMIn2dqKAI4scQI8Y64ffxFxwxPV5eqYXa4DJXnZ3O6lljxN5Vx7nDN1q+pJ0sgun+ k31dygTd5eqIc3AIpyP84YUqHuZiy+ukpKw9y9gbpPMXNGQBGO/4RBEYqSDBL0mVaj4b FkRBhzn3UkV7AsZ8KJ9W3cXKpDuLo98hgxDVu1m21aukpG7BqRqVFbbjuMfuTGRX70eJ KXYYA+tQ132Y0ACkp1Mhrs5CiMXPY0LUWNMBTa1qdO7nj1c4hNsYuit2uzDfuwGGfrKH h0gA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w18si579092ejk.400.2020.11.25.04.00.09; Wed, 25 Nov 2020 04:00:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727661AbgKYL5o (ORCPT + 99 others); Wed, 25 Nov 2020 06:57:44 -0500 Received: from ozlabs.org ([203.11.71.1]:52839 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbgKYL5n (ORCPT ); Wed, 25 Nov 2020 06:57:43 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 4Cgzsd48jmz9sTR; Wed, 25 Nov 2020 22:57:41 +1100 (AEDT) From: Michael Ellerman To: linux-kernel@vger.kernel.org, Ard Biesheuvel Cc: Daniel Borkmann , Geert Uytterhoeven , Paul Mackerras , Nick Desaulniers , Thomas Gleixner , Kees Cook , Arvind Sankar , Peter Zijlstra , Alexei Starovoitov , Randy Dunlap , Josh Poimboeuf , linuxppc-dev@lists.ozlabs.org In-Reply-To: <20201028080433.26799-1-ardb@kernel.org> References: <20201028080433.26799-1-ardb@kernel.org> Subject: Re: [PATCH] powerpc: avoid broken GCC __attribute__((optimize)) Message-Id: <160630540052.2174375.9307119240987760572.b4-ty@ellerman.id.au> Date: Wed, 25 Nov 2020 22:57:41 +1100 (AEDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2020 09:04:33 +0100, Ard Biesheuvel wrote: > Commit 7053f80d9696 ("powerpc/64: Prevent stack protection in early boot") > introduced a couple of uses of __attribute__((optimize)) with function > scope, to disable the stack protector in some early boot code. > > Unfortunately, and this is documented in the GCC man pages [0], overriding > function attributes for optimization is broken, and is only supported for > debug scenarios, not for production: the problem appears to be that > setting GCC -f flags using this method will cause it to forget about some > or all other optimization settings that have been applied. > > [...] Applied to powerpc/next. [1/1] powerpc: Avoid broken GCC __attribute__((optimize)) https://git.kernel.org/powerpc/c/a7223f5bfcaeade4a86d35263493bcda6c940891 cheers